Ticket #1485657 (closed Patches: fixed)

Opened 20 months ago

Last modified 5 months ago

Patch - contact groups for address book.

Reported by: cstdenis Owned by: thomasb
Priority: 5 Milestone: 0.4-beta
Component: Addressbook Version: 0.2-beta
Severity: normal Keywords:
Cc: phpwalter@…, todd.trann@…

Description

Attached is a patch and some new images to add contact groups to 0.2beta.

It has only been tested with postgresql, but I have added the database changes to the mysql files in SQL as well. I have not made the changes for other database types but it should be trivial to do for anyone familiar with them.

These patches probably don't completely play nice with LDAP, I don't have an ldap server here to test with.

zip file contains 6 images to put in skins/default/images/buttons.

Attachments

contactgroup_buttons.zip (176.2 KB) - added by cstdenis 20 months ago.
contact_groups.diff (47.9 KB) - added by cstdenis 20 months ago.

Change History

Changed 20 months ago by cstdenis

Changed 20 months ago by cstdenis

  Changed 20 months ago by alec

  • milestone set to 0.4-beta

It would be better to make many-to-many relation between contacts and groups.

  Changed 15 months ago by corbosman

Anyone able to update this for current SVN? maybe we can get it into core.

follow-ups: ↓ 4 ↓ 5   Changed 15 months ago by cstdenis

I am running 0.2.1 with a modified version of these patches. The only major change is a complete rewrite the auto-complete support to work with the new auto-complete system and some bug fixes.

If there is serious interest getting it into trunk I can make a new set of diffs, but it's a lot of work since I have to separate out all my other mods (nothing else really useful to give back to the community unfortunately) so I won't bother doing it unless there is serious interest.

in reply to: ↑ 3   Changed 14 months ago by lacri

Replying to cstdenis:

I am running 0.2.1 with a modified version of these patches. The only major change is a complete rewrite the auto-complete support to work with the new auto-complete system and some bug fixes. If there is serious interest getting it into trunk I can make a new set of diffs, but it's a lot of work since I have to separate out all my other mods (nothing else really useful to give back to the community unfortunately) so I won't bother doing it unless there is serious interest.

This sounds great you have my vote for a new set of diffs !!!

in reply to: ↑ 3   Changed 13 months ago by miseryshining

Replying to cstdenis: Here's serious interest! Any chance you're going to update the patch?

follow-up: ↓ 7   Changed 9 months ago by sf_basilix

I'm also interested in having this in the latest release. This apparently wasn't in the nightly build and I am unable to patch the latest nightly build - it appears that too much is different, so patch rejects most of the diffs.

in reply to: ↑ 6   Changed 9 months ago by sf_basilix

Replying to sf_basilix:

I'm also interested in having this in the latest release. This apparently wasn't in the nightly build and I am unable to patch the latest nightly build - it appears that too much is different, so patch rejects most of the diffs.

I take this back - it doesn't patch with the latest 0.3.1 either. Any chance this can be included in the next release or even better yet, in the nightly builds?

  Changed 8 months ago by phpwalter

  • cc phpwalter@… added

1) Contacts should function similar to GOOGLE:

Any contact can belong to multiple groups

2) Syncing with Google, with this type of "grouping"

would be outstanding

  Changed 6 months ago by thomasb

  • owner set to thomasb
  • status changed from new to assigned

  Changed 6 months ago by toddtrann

  • cc todd.trann@… added

We use Sun Java Messaging for email and calendar here. I just got the address book functionality working for round-trip editing the Sun LDAP address book this afternoon. It all worked with no code changes, just configuration changes (but a few hours of head-banging).

I'm going to look at the diff set in this ticket shortly, I'm interested how this author implemented groups, and indeed how compatible this change is with an LDAP address book.

Todd

  Changed 6 months ago by toddtrann

In looking at the changes suggested to the database, I do not agree with this patch. Notice that each user may be only part of one group:

ALTER TABLE contacts ADD contact_group_id int(11) DEFAULT '0';

This also does not work with LDAP, where each user may be a part of many groups. I think we need two new tables here, one to hold the groups, and the other to associate contacts to groups.

Todd

  Changed 6 months ago by corbosman

What about groups being part of groups?

  Changed 6 months ago by toddtrann

My opinion is that groups should not be members of groups, but I can see the point. I'm just thinking about the complexity of programming. :)

  Changed 5 months ago by thomasb

  • status changed from assigned to closed
  • resolution set to fixed

Groups feature is now available in trunk

Note: See TracTickets for help on using tickets.