Fail to send mail if the name of the sender contains a @

[Hosteurope]

If the Name of the From/CC/BCC/To contains a @ the mailserver doesn't acceppt the message because the name issn't correctly quoted.

[alec]

There's no problem with names from addressbook and identities.

[Hosteurope]

Replying to Hosteurope:

If the Name of the From/CC/BCC/To contains a @ the mailserver doesn't acceppt the message because the name issn't correctly quoted.

Ok, To/CC/BCC is correkt quoted, but From is not.

If you use an identity with xyz@… as name and xyz@… as E-Mail-Adress the name isn't quoted.

[alec]

Replying to Hosteurope:

If you use an identity with xyz@… as name and xyz@… as E-Mail-Adress the name isn't quoted.

Fixed in r2193.

[robin]

Closing the ticket, fix is confirmed.

[alec]

Not exactly, we should add quoting for names entered by users in compose fields. Those from addressbook and identities don't need this now.

[robin]

Replying to alec:

Not exactly, we should add quoting for names entered by users in compose fields.

Sorry, missed that...

Does following break any existing functionallity?

--- program/steps/mail/sendmail.inc     (revision 2196)
+++ program/steps/mail/sendmail.inc     (working copy)
@@ -153,8 +153,8 @@
 $input_charset = $OUTPUT->get_charset();
 $message_charset = isset($_POST['_charset']) ? $_POST['_charset'] : $input_charset;

-$mailto_regexp = array('/[,;]\s*[\r\n]+/', '/[\r\n]+/', '/[,;]\s*$/m', '/;/', '/(\S{1})(<\S+@\S+>)/U');
-$mailto_replace = array(', ', ', ', '', ',', '\\1 \\2');
+$mailto_regexp = array('/[,;]\s*[\r\n]+/', '/[\r\n]+/', '/[,;]\s*$/m', '/;/', '/(.*)\s*(<\S+@\S+>)/U');
+$mailto_replace = array(', ', ', ', '', ',', '"\\1" \\2');

 // replace new lines and strip ending ', ', make address strings more valid also
 $mailto = preg_replace($mailto_regexp, $mailto_replace, get_input_value('_to', RCUBE_INPUT_POST, TRUE, $message_charset));

I modified only the 5th expression.

[alec]

Fixed in r2234.