Incorrect Mysql schema

[ghostks]

You are using:

datetime NOT NULL DEFAULT '0000-00-00 00:00:00'

default values for datetime fields, but it's incorrect. Some Mysql servers which are not using STRICT syntax possibly will execute it but all others will deny you from executing such malformed query. Correct one is:

datetime NOT NULL DEFAULT '1000-01-01 00:00:00'

"The DATETIME type is used when you need values that contain both date and time information. MySQL retrieves and displays DATETIME values in 'YYYY-MM-DD HH:MM:SS' format. The supported range is '1000-01-01 00:00:00' to '9999-12-31 23:59:59'."
​http://dev.mysql.com/doc/refman/5.0/en/datetime.html

[Lazlo]

Ie created a patch for this. See attachment.

[alec]

For me (a postgres user) it looks strange. It wouldn't be better to use DEFAULT NULL?

[Lazlo]

Replying to alec:

For me (a postgres user) it looks strange. It wouldn't be better to use DEFAULT NULL?

You can't drop the NOT NULL (e.g. you're not allowed to add cache entries without timestamp), but you can drop the DEFAULT.

[Lazlo]

Patch with no DEFAULT value

[Lazlo]

Patch with no DEFAULT value

[alec]

First patch applied in [37974e24] as more safe.