Opened 5 years ago

Closed 5 years ago

#1485611 closed Bugs (fixed)

organization header not showing up

Reported by: ldeviator Owned by:
Priority: 5 Milestone: 0.2-stable
Component: Core functionality Version: git-master
Severity: normal Keywords:
Cc: ld@…

Description

organization is in rcmail_message_headers() but it depends on it being in the backend IMAP functions.. but it's not in there

the attached patch brings in organization so it'll display on message headers

Attachments (1)

organization in backend.patch (769 bytes) - added by ldeviator 5 years ago.
patch to IMAP functions to bring in organization header

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by ldeviator

patch to IMAP functions to bring in organization header

comment:1 Changed 5 years ago by alec

  • Component changed from IMAP connection to Core functionality

Do we realy need that non-standard header here?

comment:2 Changed 5 years ago by ldeviator

maybe not :) but we definitely use it here

though I think that the array $standard_headers inside rcmail_message_headers() should be a config option. For instance, some people might only want to see Subject, From, and Date to abbreviate the headers for smaller displays (Thunderbird, for instance, has that option)

in any case, "organization" was already included in rcmail_message_headers() in steps/mail/func.inc, it just wasn't in the backend IMAP connection (imap.inc), so I thought it may have been a bug... and since we want to see it here, I put it in there

comment:3 Changed 5 years ago by ldeviator

  • Cc ld@… added

comment:4 Changed 5 years ago by alec

I'm just saying, maybe we don't want to see it here ;) Specially when we have 'show all headers' feature now.

comment:5 Changed 5 years ago by alec

  • Resolution set to fixed
  • Status changed from new to closed

So, my decision is to remove it from standard_headers (r.2140)

Note: See TracTickets for help on using tickets.