"Unknown Server Error" with numerical-only IMAP folder names

[mattjgalloway]

I found a bug whereby if you have folders with purely numeric names (such as 2007 or 2008) then the AJAX request gets confused as the json_serialize function in rcube_shared.inc decides that the string is numeric and therefore doesn't put the folder name in quotes.

I fixed it on my server with the following changes.

program/steps/mail/getunread.inc:

$OUTPUT->command('set_unread_count', $mbox_row, $IMAP->messagecount($mbox_row, 'UNSEEN'), ($IMAP->get_mailbox_name() == 'INBOX' && $mbox_row == 'INBOX'));

goes to

$OUTPUT->command('set_unread_count', (string)$mbox_row, $IMAP->messagecount($mbox_row, 'UNSEEN'), ($IMAP->get_mailbox_name() == 'INBOX' && $mbox_row == 'INBOX'));

program/include/rcube_shared.inc:json_serialize($var):[[BR]]

else if (is_numeric($var) && strval(intval($var)) === strval($var))

goes to

else if (is_numeric($var) && (strval(intval($var)) === strval($var)) && (!is_string($var)))

It might be better to fix it in a cleaner way, although I actually think this is probably the cleanest method anyway.

Regards,
Matt Galloway

[alec]

Fixed in [8498dce5]. Slightly different, because there were other problems with numeric folder names.