Opened 5 years ago

Closed 4 years ago

#1485455 closed Bugs (fixed)

checkboxes in Opera are too small and do not have a padding

Reported by: tensor Owned by:
Priority: 5 Milestone: 0.2-stable
Component: User Interface Version: 0.2-beta
Severity: trivial Keywords:
Cc:

Description

See the screenshot.

Attachments (2)

checkboxes.PNG (6.1 KB) - added by tensor 5 years ago.
css.r2166.patch (1.4 KB) - added by JohnDoh 4 years ago.

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by tensor

comment:1 Changed 5 years ago by alec

Opera doesn't like checkboxes styling. My proposition is:

--- common.old  2008-09-19 08:19:30.000000000 +0200
+++ common.css  2008-10-09 09:48:33.833477830 +0200
@@ -63,7 +63,10 @@
   border-style: none;
 }

-input, textarea
+input[type="text"],
+input[type="button"],
+input[type="password"],
+textarea
 {
   font-size: 9pt;
   font-family: "Lucida Grande", Verdana, Arial, Helvetica, sans-serif;
@@ -75,14 +78,6 @@
   border: 1px solid #666666;
 }

-input[type="checkbox"],
-input[type="radio"]
-{
-  border: 0;
-  padding: 0;
-  background-color: transparent;
-}
-
 input.button
 {
   height: 20px;

For me it looks good with Opera, Firefox and IE7, but probably will be problem with IE6.

comment:2 Changed 5 years ago by tensor

Looks good in FF, Opera and IE 7. I have not yet tested IE 6.
Another touch to make it perfect in Opera:

=== program/steps/addressbook/import.inc
==================================================================
--- program/steps/addressbook/import.inc        (revision 2052)
+++ program/steps/addressbook/import.inc        (local)
@@ -32,7 +32,7 @@
   $form = html::p(null, html::label('rcmimportfile', rcube_label('importfromfile')) . html::br() . $upload->show());
   
   $check_replace = new html_checkbox(array('name' => '_replace', 'value' => 1, 'id' => 'rcmimportreplace'));
-  $form .= html::p(null, $check_replace->show(get_input_value('_replace', RCUBE_INPUT_GPC)) .
+  $form .= html::p(null, $check_replace->show(get_input_value('_replace', RCUBE_INPUT_GPC)) . ' ' .
     html::label('rcmimportreplace', rcube_label('importreplace')));
   
   $OUTPUT->add_label('selectimportfile','importwait');

comment:3 Changed 5 years ago by alec

Tested with IE6, checkboxes looks good, but text inputs aren't styled. I'm no sure what's better.

comment:4 Changed 4 years ago by alec

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [6291c90b]

comment:5 Changed 4 years ago by JohnDoh

  • Resolution fixed deleted
  • Status changed from closed to reopened

as alec said this patch breaks all the styling of input boxes in IE6 which really screws with the display. I attached a new patch that will fix the checkboxes in Opera and keep the styling working in IE6

Changed 4 years ago by JohnDoh

comment:6 Changed 4 years ago by alec

  • Resolution set to fixed
  • Status changed from reopened to closed

I think changes [6291c90b] and [c2af7eb6] are better than your last patch. (With you hanges checkboxes in Opera looks not perfect still)

Note: See TracTickets for help on using tickets.