Opened 5 years ago

Closed 5 years ago

#1485442 closed Bugs (fixed)

cannot download attachment

Reported by: tensor Owned by:
Priority: 5 Milestone: 0.2-stable
Component: Client Scripts Version: 0.2-beta
Severity: major Keywords:
Cc:

Description

Suddenly I was unable to download attachments.
The patch below seems to fix this, but I am not sure that this hack should be applied to show.inc.

=== show.inc
==================================================================
--- show.inc    (/mirror/rc/trunk/roundcubemail/program/steps/mail/show.inc)    (revision 1967)
+++ show.inc    (/local/rc/trunk/roundcubemail/program/steps/mail/show.inc)     (local)
@@ -74,6 +74,7 @@
   $OUTPUT->set_env('safemode', $MESSAGE->is_safe);
   $OUTPUT->set_env('sender', $MESSAGE->sender['string']);
   $OUTPUT->set_env('permaurl', rcmail_url('show', array('_uid' => $MESSAGE->uid, '_mbox' => $mbox_name)));
+  $OUTPUT->set_env('mailbox', $mbox_name);
   
   // check for unset disposition notification
   if ($MESSAGE->headers->mdn_to &&

The root cause is that something does not pass mailbox in "load-attachment" command. When the piece of code below executes, this.env.mailbox is undefined and the generated URL is incorrect.

      case 'load-attachment':
        var qstring = '_mbox='+urlencode(this.env.mailbox)+'&_uid='+this.env.uid+'&_part='+props.part;

The workaround is to copy the address of the attachment link and paste it into the browser address bar. Luckily the link is generated "statically" in PHP.

Change History (1)

comment:1 Changed 5 years ago by alec

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [2cc1cac7].

Note: See TracTickets for help on using tickets.