Opened 6 years ago

Closed 6 years ago

#1485430 closed Feature Patches (fixed)

IE can't download attach file

Reported by: joungkyun Owned by:
Priority: 5 Milestone: 0.2-stable
Component: PHP backend Version: 0.1.1
Severity: major Keywords:
Cc:

Description

roundcubemail is solved http://support.microsoft.com/kb/323308 issue
with follow code

:: webmail/program/steps/mail/get.inc 78 lines

    if (isset($_SERVER['HTTPS']))
      {
      header('Pragma: ');
      header('Cache-Control: ');
      }

But, some php build without $_SERVERHTTPS?, so, this code is useless. so fixed follows

if (preg_match('/MSIE/', $_SERVER['HTTP_USER_AGENT']) && (isset($_SERVER['HTTPS']) || $_SERVER['SERVER_PORT'] == '443'))

Attachments (1)

roundcubemail-0.1.1-ie-ssl-attach-download.patch (667 bytes) - added by joungkyun 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by alec

  • Component changed from Client Scripts to PHP backend
  • Milestone changed from later to 0.2-stable

comment:2 in reply to: ↑ description ; follow-up: Changed 6 years ago by tensor

Replying to joungkyun:
What OS and IE version do you use?
Implementing this patch as is may harm other user's IE (including IE 7 and fixed IE 6 versions). IE 5.5 and below are not supoorted by RC.

comment:3 in reply to: ↑ 2 ; follow-up: Changed 6 years ago by joungkyun

Replying to tensor:

Replying to joungkyun:
What OS and IE version do you use?
Implementing this patch as is may harm other user's IE (including IE 7 and fixed IE 6 versions). IE 5.5 and below are not supoorted by RC.

I tested follow environments

    Server: PHP 5.2.6 + SSL (HTTPS connection)

    1. Windows Vista SP1 + IE 7 (Korean)
    2. Windows XP SP3 + IE 6 (Korean)
    3. Windows XP SP3 + IE 7 (Korean)

I have download problem all case. And, my php don't have HTTPS variable in _SERVER gloable variables. So, After applied my patch, I solved attache file download problem.

comment:4 in reply to: ↑ 3 Changed 6 years ago by joungkyun

Replying to joungkyun:

Replying to tensor:

Replying to joungkyun:
What OS and IE version do you use?
Implementing this patch as is may harm other user's IE (including IE 7 and fixed IE 6 versions). IE 5.5 and below are not supoorted by RC.

I tested follow environments

    Server: PHP 5.2.6 + SSL (HTTPS connection)

    1. Windows Vista SP1 + IE 7 (Korean)
    2. Windows XP SP3 + IE 6 (Korean)
    3. Windows XP SP3 + IE 7 (Korean)

I have download problem all case. And, my php don't have HTTPS variable in _SERVER gloable variables. So, After applied my patch, I solved attache file download problem.

Firefox 2/3 has no problems whether upper header is set or not set.

comment:5 follow-up: Changed 6 years ago by tensor

joungkyun, can you provide a test account at your mail server? you can send me private email to dennis at nikolaenko dot ru

Are you using 0.1.1 RC version?

comment:6 in reply to: ↑ 5 Changed 6 years ago by joungkyun

Replying to tensor:

joungkyun, can you provide a test account at your mail server? you can send me private email to dennis at nikolaenko dot ru

send to dennis at nikolaenko dot ru.

Are you using 0.1.1 RC version?

I'm using 0.1.1 stable + http://trac.roundcube.net/ticket/1484991 patch

comment:7 Changed 6 years ago by tensor

I tested joungkyun's server, it runs 0.1.1.
This issue has been definitely solved in the trunk. This ticket can be closed. As the 0.2-stable release is going to be released soon, I believe it is not worth the trouble to backport to 0.1 series.

comment:8 Changed 6 years ago by alec

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.