Opened 5 years ago

Closed 5 years ago

#1485244 closed Feature Patches (invalid)

Installer: No need for magic_quotes_gpc check

Reported by: flurischt Owned by: thomasb
Priority: 5 Milestone: 0.2-beta
Component: Installer Version: git-master
Severity: minor Keywords: installer, magic_quotes_gpc
Cc:

Description

Hi,

In my opinion, theres no need to check for magic_quotes_gpc while installaing.
At Runtime RC sets in program/include/iniset.php magic_quotes_gpc to 0.

Why not do the same in the installer and skip the check. (See my patch)

For some Users its a problem to deactivate magic_quotes_gpc. If php is loaded as cgi ".htacces php_value" wont work and they probably dont have access to the php.ini...

Attachments (1)

installer-magic_quotes_gpc.diff​ (1.0 KB) - added by flurischt 5 years ago.
Patch for RC installer script (no magic_quotes_gpc check)

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by flurischt

Patch for RC installer script (no magic_quotes_gpc check)

comment:1 Changed 5 years ago by thomasb

  • Owner set to thomasb

But then we need to check the result of set_magic_quotes_runtime() to make sure that this operation works.

comment:2 Changed 5 years ago by flurischt

damn, i tested it again and my patch wont work.

set_magic_qoutes_runtime() doesnt affect magic_quotes_gpc.

you can close this ticket. --> sorry!

comment:3 Changed 5 years ago by alec

  • Milestone changed from 0.2-stable to 0.2-beta
  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.