Opened 6 years ago

Closed 6 years ago

#1485215 closed Feature Patches (fixed)

config file location

Reported by: schmonz Owned by:
Priority: 5 Milestone: 0.2-beta
Component: Core functionality Version: 0.1.1
Severity: normal Keywords:
Cc: till

Description

The attached patch enables RoundCube config files to be stored in an alternate location. The default location remains "config", and can be changed by editing a define in index.php.

Attachments (2)

roundcube-config-dir2.diff (1.7 KB) - added by schmonz 6 years ago.
roundcube-config-dir3.diff (4.2 KB) - added by schmonz 6 years ago.
updated patch for 0.2-alpha

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by schmonz

comment:1 Changed 6 years ago by till

  • Cc till added; klimpong@… removed

I'd probably make the constant dirname(__FILE__) . '/config'. Otherwise looking good to me. If no one else has an objection, I'd commit this soon.

comment:2 follow-up: Changed 6 years ago by thomasb

Remember, index.php is not always used (see bin/*.php)

Make sure that this new constant is alwas defined as done with INSTALL_PATH in iniset.php or define it directly in iniset.php instead of index.php

Changed 6 years ago by schmonz

updated patch for 0.2-alpha

comment:3 in reply to: ↑ 2 Changed 6 years ago by schmonz

thomasb, I've done just as you said: the new constant is defined in iniset.php now. (Don't mind the '@PKG_SYSCONFDIR@' bit, that'll be a local patch in our package system; remove it and comment in the other define.)

till, I don't understand that PHP syntax, but feel free to do as you like. :-)

I can't vouch for the installer, but otherwise everything seems to work fine here with this updated patch.

comment:4 Changed 6 years ago by schmonz

Any word on this? I see there's lots of activity in svn -- would be great if this were included in time for the next snapshot. Thanks!

comment:5 Changed 6 years ago by thomasb

  • Milestone changed from later to 0.2-beta
  • Resolution set to fixed
  • Status changed from new to closed

Added in [bba657e6]

Please note that the RCMAIL_CONFIG_DIR constant has to be changed in installer/index.php as well as in in program/include/iniset.php)

Note: See TracTickets for help on using tickets.