Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1485097 closed Feature Patches (fixed)

Re-enable background attribute in HTML messages (broken in r1452)

Reported by: brian Owned by:
Priority: 5 Milestone: 0.2-beta
Component: Client Scripts Version: 0.1.1
Severity: normal Keywords:
Cc:

Description

The update to the washtml library disabled the display of background images used in divs and tables. This one is very easy to patch.

In the folder: /program/lib/
In the file: washtml.php
In line: 80
Change the $html_attribs to include background as an allowed attribute.

Updated line:

  /* Allowed HTML attributes */
  static $html_attribs = array('name', 'class', 'title', 'alt', 'width', 'height', 'align', 'nowrap', 'col', 'row', 'id', 'rowspan', 'colspan', 'cellspacing', 'cellpadding', 'valign', 'bgcolor', 'color', 'border', 'bordercolorlight', 'bordercolordark', 'face', 'marginwidth', 'marginheight', 'axis', 'border', 'abbr', 'char', 'charoff', 'clear', 'compact', 'coords', 'vspace', 'hspace', 'cellborder', 'size', 'lang', 'dir', 'background');

Change History (2)

comment:1 Changed 5 years ago by alec

  • Milestone changed from later to 0.2-beta
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [18ebb902].

comment:2 Changed 5 years ago by storney

Lasted Update:

/* Allowed HTML attributes */
static $html_attribs = array('name', 'class', 'title', 'alt', 'width', 'height', 'align', 'nowrap', 'col', 'row', 'id', 'rowspan', 'colspan', 'cellspacing', 'cellpadding', 'valign', 'bgcolor', 'color', 'border', 'bordercolorlight', 'bordercolordark', 'face', 'marginwidth', 'marginheight', 'axis', 'border', 'abbr', 'char', 'charoff', 'clear', 'compact', 'coords', 'vspace', 'hspace', 'cellborder', 'size', 'lang', 'dir', 'background');

more update: check this

Note: See TracTickets for help on using tickets.