rcube_charset_convert() does not verify whether iconv() worked

[dog]

In rcube_charset_convert() there is the following code:

  // convert charset using iconv module  
  if (function_exists('iconv') && $from != 'UTF-7' && $to != 'UTF-7')
    {
    $aliases['GB2312'] = 'GB18030';
    return iconv(($aliases[$from] ? $aliases[$from] : $from), ($aliases[$to] ? $aliases[$to] : $to) . "//IGNORE", $str);
    }

This does not verify that iconv() acutally worked. For me this resulted in getting "IMAP Error: Invalid login" errors in a shared hosting environment.

Writing the line as

$iconvRes = iconv(($aliases[$from] ? $aliases[$from] : $from), ($aliases[$to] ? $aliases[$to] : $to) . "//IGNORE", $str);
if($iconvRes !== FALSE)
	return $iconvRes;

fixed my problem.

[till]

Can you supply an example of what caused this?

[till]

Added an additonal check in r1424, but please supply an example so we may be able to fix the real cause.

[dog]

Adding a breakpoint to the iconv() function reveals that it failed at

a1: UTF-7 
a2: ISO-8859-1//IGNORE 
a3: INBOX

Trying this with error_reporting shows the following message:

Notice: iconv() [function.iconv]: Wrong charset, conversion from `UTF-7' to `ISO-8859-1' is not allowed in /[...]test.php on line 10

This is in a shared hosting environment so I can not exactly say what causes this error.

[alec]

Fixed in r1424. Closing it as we haven't got test.php yet.

[dog]

<?php
	error_reporting(E_ALL);
	ini_set('display_errors','On');

	echo iconv("UTF-7","ISO-8859-1","INBOX");

?>

(rest of the file removed as it does not matter for the error)

I would appreciate a bit more 'proactiveness' here as the error message from PHP already says everything.