Ticket #1485076 (reopened Patches)

Opened 7 months ago

Last modified 2 months ago

Reuse HTTP authentication for login

Reported by: dfoerster Owned by:
Priority: 5 Milestone: later
Component: Client Scripts Version: 0.1.1
Severity: normal Keywords: login, http authentication
Cc: rasky@…

Description

Hi,

the attached patch allows to reuse HTTP authentication credentials for the login. If the webmail installation is protected by HTTP authentication with matching credentials, the user only needs to enter them once.

The feature needs to be enabled by a configuration option.

It's working fine for me but the patch could be refactored a little bit by someone with some more knowledge about roundcube's internals. It applies to the 0.1.1 version.

Regards David

Attachments

reuse-http-auth.diff (1.8 kB) - added by dfoerster 7 months ago.
http_auth_svn.diff (1.3 kB) - added by ryanroth 6 months ago.
Fixed for SVN and small refresh issue

Change History

Changed 7 months ago by dfoerster

Changed 6 months ago by thomasb

  • status changed from new to closed
  • resolution set to duplicate
  • milestone deleted

Duplicate of #1388203

Changed 6 months ago by ryanroth

Can you update this to work with the current SVN?

Changed 6 months ago by ryanroth

http://trac.roundcube.net/ticket/1388203 does not work with the current release or SVN

Changed 6 months ago by ryanroth

  • status changed from closed to reopened
  • resolution deleted

Changed 6 months ago by ryanroth

Fixed for SVN and small refresh issue

Changed 4 months ago by dan

thanks for the patch. It certianly helped me with bug 1485224

things i noted $host = $RCMAIL->autoselect_host(); seems unneeded as login can just take username/password and it seems to workout the host then.

$OUTPUT->redirect() instead of header( 'refresh: 1'); for consistency with the login.

i didn't bother with cookie checking as i think that is done elsewhere

logouts don't particularly work when the authentication is already there. (I don't know how to fix this either)

you could use the email2user functions to handle virtual users.

your patch doesn't include the main.inc.php.dist change to enable http authenticaion

Changed 3 months ago by alec

  • milestone set to later

Changed 2 months ago by rasky@…

  • cc rasky@… added

As explained in a duplicate bug (which contained more infos than this bug...), a quick way to disable the useless logout button is to put "display: none" in the CSS. Obviously, a correct fix has to be done elsewhere.

Note: See TracTickets for help on using tickets.