Ticket #1485066 (closed Bugs: fixed)

Opened 7 months ago

Last modified 7 months ago

delete_all method of rcube_contacts has extraneous code

Reported by: sj26 Owned by:
Priority: 5 Milestone: 0.2-alpha
Component: Core functionality Version: 0.1.1
Severity: minor Keywords:
Cc:

Description

Changeset [1126] introduced a method to rcube_contacts called delete_all. This currently had some extraneous code which causes notices in php error logs:

    if (is_array($ids))
      $ids = join(',', $ids);

Variable $ids does not exit.

This appears to be because the delete_all methods was copied from the delete method which had this variable as a parameter and uses it in the SQL query.

Change History

Changed 7 months ago by alec

  • status changed from new to closed
  • resolution set to fixed
  • milestone changed from later to 0.1.2

Fixed in r1387. Thanks.

Note: See TracTickets for help on using tickets.