Opened 5 years ago

Closed 4 years ago

#1485063 closed Bugs (fixed)

abbreviate_string in get.inc

Reported by: simplexe Owned by:
Priority: 5 Milestone: 0.2-stable
Component: Client Scripts Version: 0.1.1
Severity: normal Keywords:
Cc:

Description

hi, in file get.inc function abbreviate_string have secondary param 55 for IE, i added if<>else for other browsers. see diff.
Also, when i save attached file on disk and filename in cyrillic encoding - in IE, filename (not extension!) broken. i use iconv() function for encoding, so:

      $browser   = new rcube_browser();
      if ($browser->win && $_SERVER['HTTP_ACCEPT_LANGUAGE'] == 'ru' && $browser->ie)
        {
        $part->filename = iconv("UTF-8", "Windows-1251", $part->filename);
        }

i not found other decision =(

Attachments (4)

only_ie_hack.diff​ (1.2 KB) - added by simplexe 5 years ago.
filename_on_browser.bmp​ (46.0 KB) - added by simplexe 5 years ago.
in preview panel (IE)
save_on_disk_no_iconv.bmp​ (128.8 KB) - added by simplexe 5 years ago.
no iconv()
save_on_disk_wich_iconv.6.bmp​ (96.3 KB) - added by simplexe 5 years ago.
with iconv()

Download all attachments as: .zip

Change History (11)

Changed 5 years ago by simplexe

Changed 5 years ago by simplexe

in preview panel (IE)

Changed 5 years ago by simplexe

no iconv()

Changed 5 years ago by simplexe

with iconv()

comment:1 Changed 5 years ago by alec

  • Milestone changed from later to 0.1.2

comment:2 Changed 5 years ago by till

  • Milestone changed from 0.1.2 to 0.1.5

So it's only broken in Internet Explorer and works in all other browsers?

I'd suggest you use MultiByte? instead of iconv.

comment:3 Changed 5 years ago by simplexe

Yes, only IE, other works good. IMO IE use system encoding for save file. Maybe it is worth to write a feature to specify the encoding IE?

comment:4 Changed 5 years ago by simplexe

after my experiments, i found trouble - IE don't send Accept charset to server, only language.

comment:5 Changed 5 years ago by anonymous

  • Milestone 0.1.5 deleted

Milestone 0.1.5 deleted

comment:6 Changed 5 years ago by alec

  • Milestone set to 0.2-beta

comment:7 Changed 4 years ago by thomasb

  • Resolution set to fixed
  • Status changed from new to closed

Abbreviation only for IE added in [f1cc7fc0].
Also file names are now url-encoded for IE browsers.

Note: See TracTickets for help on using tickets.