Ticket #1485051 (closed Bugs: fixed)

Opened 5 months ago

Last modified 5 months ago

Don't attempt to delete cache entries if enable_caching is FALSE

Reported by: jeblair Owned by:
Priority: 5 Milestone: 0.2-alpha
Component: Core functionality Version: 0.1.1
Severity: normal Keywords: cache caching
Cc:

Description

RoundCube attempts to delete entries from the "cache" and "messages" tables, even if enable_caching is turned off. I am attaching a patch that checks that config option before attempting to delete from those tables. This optimization lets admins omit those tables from their environment entirely.

Attachments

db.diff (1.1 kB) - added by jeblair 5 months ago.
check enable_caching before issuing deletes from cache tables
rcube_imap.diff (371 bytes) - added by jeblair 5 months ago.
Patch to rcube_imap.inc to test for caching when clearing the cache

Change History

Changed 5 months ago by jeblair

check enable_caching before issuing deletes from cache tables

Changed 5 months ago by alec

  • status changed from new to closed
  • resolution set to fixed
  • component changed from Client to Core functionality
  • milestone changed from later to 0.1.2

Fixed in r1362. Thanks.

Changed 5 months ago by jeblair

Patch to rcube_imap.inc to test for caching when clearing the cache

Changed 5 months ago by jeblair

  • status changed from closed to reopened
  • resolution deleted

Hi, thanks for fixing that. I found one more place where RoundCube should test for caching before clearing a cache: that's in rcube_imap.inc. There are two functions that clear a cache: clear_cache and clear_message_cache. clear_message_cache already had a check to test whether caching was enabled. The patch I attached adds the same check to clear_cache.

Changed 5 months ago by alec

  • status changed from reopened to closed
  • resolution set to fixed

Fixed in r1380.

Note: See TracTickets for help on using tickets.