Ticket #1485048 (closed Patches: fixed)

Opened 7 months ago

Last modified 7 months ago

Bugfix with decode_mime_string(From/To) in Changeset 1355

Reported by: Javer Owned by:
Priority: 8 Milestone: 0.2-alpha
Component: PHP backend Version: svn-trunk
Severity: critical Keywords:
Cc:

Description

Changeset 1355, which add decode_mime_string around From and To fields of messages, is incorrect, and now From and To fields in messages list are displayed incorrectly. This is because processing of From/To fields looks like this:

$input = rcube_imap::decode_mime_string($input)
rcmail_address_string($input)
|-> $IMAP->decode_address_list($input)
    |-> $IMAP->_parse_address_list($input, true)
        |-> $IMAP->decode_header($input)
            |-> rcube_imap::decode_mime_string($input)

Therefore, we have double using of decode_mime_string on same input value, and result value is wrong.


Solution: Remove call rcube_imap::decode_mime_string when processing From and To fields in messages list. In attached patch also added IMAP->set_charset() for using correct message charset when calling decode_mime_string() while processing rcmail_address_string().

Attachments

func-1359.diff (1.0 kB) - added by Javer 7 months ago.
Cleaned patch (set_charset moved to separate patch)

Change History

Changed 7 months ago by Javer

Cleaned patch (set_charset moved to separate patch)

Changed 7 months ago by alec

  • status changed from new to closed
  • resolution set to fixed

Fixed in r1366.

Note: See TracTickets for help on using tickets.