Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#1485031 closed Feature Patches (fixed)

Multiple Skin Selector

Reported by: bpat1434 Owned by:
Priority: 5 Milestone: later
Component: User Interface Version: git-master
Severity: minor Keywords:
Cc:

Description

This feature has been requested a lot in the forums. And with the ability for people to create their own skin, I think we should allow individual users the opportunity to choose which skin they'd like to use.

Attached to this ticket is my diff file from the latest trunk on 4/29/08 (rev 1343). Essentially it works like this:

  • Admin defines the directory which holds all skins and a default skin to use with their site (defaults to "default")
  • User is then allowed to go into preferences and select a specific skin to use
  • Preference is saved in database and updated in $CONFIG array
  • rcube_template checks to make sure a skin is set, otherwise uses "default_skin" from $CONFIG

A short and easy patch. This was tested and is working against the latest trunk (1343) with both the default and mvision themes.

Attachments (2)

multi_skin.patch (3.5 KB) - added by bpat1434 5 years ago.
Patch (diff) file for use with trunk rev1343 to add multi-skin selection
multi_skin.2.patch (3.5 KB) - added by bpat1434 5 years ago.
Multiple Skin Selector now with option to turn off.

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by bpat1434

Patch (diff) file for use with trunk rev1343 to add multi-skin selection

comment:1 Changed 5 years ago by till

  • Milestone changed from 0.1.2 to later
  • Type changed from Feature Requests to Patches

I am sure not everyone wants this kind of feature, can you add a configuration option (config/main.inc.php)? enable_skinselector or something similar, if set and true, it would allow people to change skins.

Feel free to put it back into 0.1.2 if that is added.

comment:2 Changed 5 years ago by bpat1434

Till:

This takes care of tickets 1457222 and 1484744 which deal with a skin selector/chooser ;)

It does have the ability to be "turned off" just like the rest of the preference options. However the $no_override array is set, this inherits from it as well. I've also added a config variable to enable the skin selector.

Will attach a new patch to reflect these changes. I can't change the milestone, so if I see you, I'll let you know.

Changed 5 years ago by bpat1434

Multiple Skin Selector now with option to turn off.

comment:4 Changed 5 years ago by alec

  • Resolution set to fixed
  • Status changed from new to closed

Applied with some modifications in [e58df3ad].

Note: See TracTickets for help on using tickets.