Ticket #1485012 (closed Patches: fixed)

Opened 2 years ago

Last modified 5 months ago

Option not to mark messages as read when viewed in preview pane

Reported by: JohnDoh Owned by: thomasb
Priority: 5 Milestone: 0.4-beta
Component: Core functionality Version: svn-trunk
Severity: normal Keywords:
Cc:

Description

Patch adds an option to the user preferences to not mark a message as read when it is viewed in the preview pane.

Attachments

preview_not_read.patch (4.1 KB) - added by JohnDoh 2 years ago.
Here is a slightly tidyier version just incase it is useful for any one else.
rc_preview_not_read_r1556.patch (3.3 KB) - added by JohnDoh 2 years ago.
patch for rev 1556
previewnotread_r1622.patch (3.4 KB) - added by JohnDoh 2 years ago.
updated for r1622
previewnotread.r1755.patch (4.6 KB) - added by JohnDoh 2 years ago.
updated for rev1755
previewnotread.r1873.patch (4.6 KB) - added by JohnDoh 2 years ago.
Updated for the 0.2b release
previewnotread.r1903.patch (5.8 KB) - added by JohnDoh 2 years ago.
updated for rev1903
previewnotread.r2011.patch (5.8 KB) - added by JohnDoh 23 months ago.
previewnotread.r2044.patch (5.8 KB) - added by JohnDoh 22 months ago.
previewnotread.r2405.patch (5.9 KB) - added by JohnDoh 17 months ago.
previewnotread.r2435.patch (11.0 KB) - added by JohnDoh 16 months ago.
patch with new options for wait x seconds and do not mark displayed messages as read
previewnotread.r2682.patch (11.0 KB) - added by JohnDoh 14 months ago.
previewnotread.r2755.patch (11.4 KB) - added by JohnDoh 14 months ago.
previewnotread.r2833.patch (12.5 KB) - added by JohnDoh 13 months ago.
previewnotread.r3139.patch (13.7 KB) - added by JohnDoh 9 months ago.
previewnotread.r3176.patch (13.7 KB) - added by JohnDoh 9 months ago.
rc_previewnotread.r3352.patch (13.0 KB) - added by JohnDoh 6 months ago.
rc_previewnotread.r3412.patch (11.2 KB) - added by thomasb 5 months ago.
New patch with simplified user settings

Change History

Changed 2 years ago by alec

My opinion: it's useless and unwanted behaviour.

Changed 2 years ago by JohnDoh

Here is a slightly tidyier version just incase it is useful for any one else.

Changed 2 years ago by JohnDoh

patch for rev 1556

Changed 2 years ago by till

Well, questioning usefulness. Personally I have no use for it either, but ...

IMHO, it could be used with a default setting that doesn't change anything from now, but users would still be able to set this via user preferences.

So generally +1 from me.

Changed 2 years ago by JohnDoh

updated for r1622

Changed 2 years ago by JohnDoh

updated for rev1755

Changed 2 years ago by JohnDoh

Updated for the 0.2b release

Changed 2 years ago by JohnDoh

updated for rev1903

Changed 23 months ago by JohnDoh

Changed 22 months ago by JohnDoh

Changed 17 months ago by alec

  • component changed from Client Scripts to Core functionality

ok, what about displaying in message view (not in preview pane), don't we need such option there?

Changed 17 months ago by JohnDoh

personally I think it is only needed with the preview pane, when I actually open a message I expect it to be marked as read. may be there could be 2 seperate options, one for preview pane and one for message view (could always be in the advanced option section). I will attach the lastest version of the patch, I just realised I haven't been doing that for a while :/

Changed 17 months ago by JohnDoh

Changed 16 months ago by JohnDoh

patch with new options for wait x seconds and do not mark displayed messages as read

Changed 14 months ago by JohnDoh

Changed 14 months ago by JohnDoh

Changed 13 months ago by JohnDoh

Changed 9 months ago by JohnDoh

Changed 9 months ago by JohnDoh

Changed 6 months ago by JohnDoh

Changed 5 months ago by thomasb

  • milestone changed from later to 0.4-beta

I suggest to add it but without the setting for 'message_view_mark_read'. I think it's obvious that the message is read after opening it. Also I'd prefer to add only one line in the user settings page where one can choose from a drop-down: never, immediately, after 5 seconds, after 10 seconds, etc.

Changed 5 months ago by thomasb

New patch with simplified user settings

Changed 5 months ago by alec

One select in preferences, so there could be also one option. Do we need two? Would be simpler.

Changed 5 months ago by thomasb

  • owner set to thomasb
  • status changed from new to assigned

Damn you perfectionists out there :-) I'll change it when taking it into trunk.

Changed 5 months ago by thomasb

  • status changed from assigned to closed
  • resolution set to fixed

Finally committed in r3479, thanks for the patience!

Note: See TracTickets for help on using tickets.