Move message to folder also expunges messages marked as deleted

[r@…]

Steps to reproduce:

1) In main.inc.php set $rcmail_config['flag_for_deletion'] = TRUE;

2) In main.inc.php set $rcmail_config['trash_mbox'] = '';

3) Log into RC, open any folder and mark a message to be deleted

4) Drag (move) a message from the same folder above into any other folder

At this point, a few things happen:

1) The message marked as deleted in step 3 was actually expunged from the IMAP server during the move operation in step 4, but still appears in the message list

2) Clicking on "Compact" to get rid of the "phantom" message marked as deleted in step 3 fails to remove it from the message list

3) Clicking on the message marked as deleted in step 3 results in a "Could not load message from server" error, because it no longer actually exists on the server

To recover from this condition, one must click on a folder, click on the "E-mail" icon in the upper-right toolbar, or reload the page.

I believe that when 'flag_for_deletion' is set in the config file, the behavior of moving messages from one folder to another should mimic the behavior of marking messages for deletion - that is, copy the message to the new folder, but only mark the message in the original folder as deleted. Thus there is no "surprise" expunge during a message move which tramples messages already marked for deletion by the user, and avoids the resulting UI weirdness.

[thomasb]

(fixed formatting)

[till]

Err... you want to delete a message and then move it to another folder?

Maybe you should move it and be done with it?

[r@…]

Sorry I wasn't clearer. The message in step 3 and the message in step 4 are different messages. For example, if I mark message #1 for deletion, and then move message #2 to a different folder, both message #1 and message #2 are expunged from the IMAP server during the move operation. Message #1 however is not removed from RoundCube's message list, while message #2 is. Subsequent attempts to remove message #1 from the message list by "Compact"ing the folder fail. The main problem is that after a move operation, RoundCube's message list does not reflect the fact that messages marked for deletion prior to the move operation were expunged along with the moved message. Should I provide screenshots?

[alec]

Fixed in r1508.