Opened 5 years ago

Closed 5 years ago

#1484932 closed Feature Patches (fixed)

caching + ob_gzhandler + firefox = bug

Reported by: alec Owned by: till
Priority: 5 Milestone: 0.1.1
Component: PHP backend Version: git-master
Severity: major Keywords:
Cc:

Description

When in index.php is used ob_start('ob_gzhandler') I've problem in firefox (Opera works fine). When I'm clicking on messages list, sometimes (very often) firefox hangs for a while and then starts downloading some binary file. That's a pretty unfortunate problem.

I've made some investigation on it and found a solution. When RC sends "304 Not Modified" reply there's non-empty body on it (I don't know why nor from where it comes from). That is not in accordance with RFC. One solution is to clean output buffer (and turn of output buffering) before exit.

--- program/include/rcube_shared.inc.old	2008-02-25 15:14:06.000000000 +0100
+++ program/include/rcube_shared.inc	2008-03-27 11:23:28.104408435 +0100
@@ -262,7 +262,10 @@
     header("Etag: $etag");
   
   if ($iscached)
+    {
+    ob_end_clean();
     exit;
+    }
 }

Change History (3)

comment:1 Changed 5 years ago by alec

Bug and solution confirmed on rc users mailing list ​http://lists.roundcube.net/mail-archive/users/2008-03/0000031.html

comment:2 Changed 5 years ago by till

  • Milestone changed from later to 0.1.1
  • Owner set to till
  • Status changed from new to assigned

comment:3 Changed 5 years ago by till

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [1b4d7323]! Thanks!

Note: See TracTickets for help on using tickets.