Fix for hidden attachments

[Priet]

I noticed that wasn't able to view all the attachments: depending on the browser, some attachments were hidden because of the single line for attachments.

Only in Firefox that lines grows if the attachments don't fit on the line.

In IE6 the line grows but the layout is a mess.

In IE7 the line doesn't grow and some attachment can't be seen.

I changed one line and added a new one in skins/default/mail.css:

Line number 615

#attachment-list
{
  margin: 0px;
  padding: 0px 0px 0px 68px;
  min-height: 18px;
  list-style-image: none;
  list-style-type: none;
  background: url(images/icons/attachment.png) 52px 1px no-repeat #DFDFDF;
  /* css hack for IE */
  height: expression(Math.min(18, parseInt(this.clientHeight))+'px');
}

Change it to: (see _height)

#attachment-list
{
  margin: 0px;
  padding: 0px 0px 0px 68px;
  min-height: 18px;
  list-style-image: none;
  list-style-type: none;
  background: url(images/icons/attachment.png) 52px 1px no-repeat #DFDFDF;
  /* css hack for IE */
  _height: expression(Math.min(18, parseInt(this.clientHeight))+'px'); /* Notice the _ before height, only affects IE6 */
}

Line number 638

#attachment-list li
{
  float: left;
  height: 18px;
  font-size: 11px;
  padding: 2px 10px 0px 10px;
}

Change it to: (see white-space)

#attachment-list li
{
  float: left;
  height: 18px;
  font-size: 11px;
  padding: 2px 10px 0px 10px;
  white-space: nowrap; /* Added so attachments are properly aligned, each on a single line if it doesn't fit on one line */
}

Changed a _height and added a white-space. That's all! :)

[robin]

Proposed changes in diff format, please test to make sure it doesn't break other browsers:

Index: skins/default/mail.css
===================================================================
--- skins/default/mail.css	(revision 1223)
+++ skins/default/mail.css	(working copy)
@@ -622,7 +622,7 @@
   list-style-type: none;
   background: url(images/icons/attachment.png) 52px 1px no-repeat #DFDFDF;
   /* css hack for IE */
-  height: expression(Math.min(18, parseInt(this.clientHeight))+'px');
+  _height: expression(Math.min(18, parseInt(this.clientHeight))+'px');
 }
 
 #attachment-list:after
@@ -641,6 +641,7 @@
   height: 18px;
   font-size: 11px;
   padding: 2px 10px 0px 10px;
+  white-space: nowrap;
 }
 
 #attachment-list li a

[alec]

Fixed in r1391.