Opened 5 years ago
Closed 5 years ago
#1484816 closed Feature Patches (fixed)
Keypress (not keydown) for repeat
| Reported by: | rjhughes | Owned by: | |
|---|---|---|---|
| Priority: | 5 | Milestone: | 0.2-beta |
| Component: | User Interface | Version: | 0.1-rc2 |
| Severity: | normal | Keywords: | key keydown down keypress |
| Cc: |
Description
Hi. I use Firefox 2. I found that when I pressed and held the "down" key (for example), it would move down exactly one message and then stop. I would like for it to continue scrolling. This is the behavior I expect.
I found this very easy to achieve: I changed the event that is attached. Instead of "keydown", it is now attached to "keypress". This works on Firefox and Konqueror.
I have a patch against revision 1139 in the trunk.
Attachments (1)
Change History (6)
comment:1 Changed 5 years ago by seansan
- Milestone set to 0.1-stable
comment:2 Changed 5 years ago by till
- Milestone changed from 0.1-stable to 0.1.1
Before committing we should prolly test this in IE, Safari and Opera as well.
comment:3 Changed 5 years ago by rjhughes
Okay. I tested it on opera (9.50 alpha, cuz that's the only 64-bit version I could find). That worked. I tested it on Safari. That worked with the new version of the patch. I tested it on IE6. It did not work, but neither did the old "keydown" way of doing things, so I didn't make it any more broken.
Changed 5 years ago by rjhughes
Patch against 1186 to use 'keypress' instead of 'keydown' to allow for keyboard repeat by holding down the key. Updated for safari.
comment:4 Changed 5 years ago by thomasb
- Milestone changed from 0.1.1 to 0.2-beta
comment:5 Changed 5 years ago by alec
- Resolution set to fixed
- Status changed from new to closed
Patch applied in [e9b57bb8].
Not critical - review for 0.1 stable - otherwise move to 0.1.1