Ticket #1484816 (closed Patches: fixed)

Opened 10 months ago

Last modified 7 months ago

Keypress (not keydown) for repeat

Reported by: rjhughes Owned by:
Priority: 5 Milestone: 0.2-beta
Component: User Interface Version: 0.1-rc2
Severity: normal Keywords: key keydown down keypress
Cc:

Description

Hi. I use Firefox 2. I found that when I pressed and held the "down" key (for example), it would move down exactly one message and then stop. I would like for it to continue scrolling. This is the behavior I expect.

I found this very easy to achieve: I changed the event that is attached. Instead of "keydown", it is now attached to "keypress". This works on Firefox and Konqueror.

I have a patch against revision 1139 in the trunk.

Attachments

keypress.diff (1.2 kB) - added by rjhughes 10 months ago.
Patch against 1186 to use 'keypress' instead of 'keydown' to allow for keyboard repeat by holding down the key. Updated for safari.

Change History

Changed 10 months ago by seansan

  • milestone set to 0.1-stable

Not critical - review for 0.1 stable - otherwise move to 0.1.1

Changed 10 months ago by till

  • milestone changed from 0.1-stable to 0.1.1

Before committing we should prolly test this in IE, Safari and Opera as well.

Changed 10 months ago by rjhughes

Okay. I tested it on opera (9.50 alpha, cuz that's the only 64-bit version I could find). That worked. I tested it on Safari. That worked with the new version of the patch. I tested it on IE6. It did not work, but neither did the old "keydown" way of doing things, so I didn't make it any more broken.

Changed 10 months ago by rjhughes

Patch against 1186 to use 'keypress' instead of 'keydown' to allow for keyboard repeat by holding down the key. Updated for safari.

Changed 10 months ago by thomasb

  • milestone changed from 0.1.1 to 0.2-beta

Changed 7 months ago by alec

  • status changed from new to closed
  • resolution set to fixed

Patch applied in r1510.

Note: See TracTickets for help on using tickets.