Ticket #1484754 (closed Bugs: fixed)

Opened 8 months ago

Last modified 8 months ago

Remote images in HTML Mails

Reported by: zap Owned by: thomasb
Priority: 5 Milestone: 0.1-stable
Component: Client Scripts Version: svn-trunk
Severity: normal Keywords:
Cc:

Description

If you view an HTML mail with embedded remote images, those images are blocked until you decide to download them. Good.

This decision isn't remembered (not even during a session) because when you read another mail and go back to the html mail, you have to click on "Download images" again.

Beside that: If you have downloaded them and want to print the mail, the print preview doesn't render the images either and you don't even have an option to download them.

Change History

Changed 8 months ago by till

  • milestone set to 0.1-stable

Re, the "remember me" - isn't it the same in Thunderbird? ;-)

Good idea still. ;-)

Re, the print issue - sounds like a bug to me. There should be at least a button to make them show up.

Changed 8 months ago by thomasb

Printing works when opening from the message view but does not work when opening from the list view with preview pane. This is a bug.

We could save the display images decision in the current session. Looking up the sender in the local address book is a way to save it permanently. There's another ticket for this.

Changed 8 months ago by thomasb

  • status changed from new to closed
  • resolution set to fixed

Remember decision to display images during session (r1023). For a persistent display of images see #1484601

Changed 8 months ago by seansan

  • status changed from closed to reopened
  • resolution deleted

I am testing this on RC latest SVN install. both in preview pane and normal e-mail view the setting is not remembered in the same session. I have to click DISPLAY remote images every time.

Running SVN 1039 on apache, PHP5

CHANGELOG RoundCube Webmail
---------------------------

2008/02/07 (thomasb)
----------
- Remember decision to display images for a certain message during session (#1484754)

Changed 8 months ago by till

  • owner set to thomasb
  • status changed from reopened to new

I don't understand the changeset (r1023). I don't see how it works, shouldn't the "remember me"-part happen in a session?

Changed 8 months ago by thomasb

  • status changed from new to closed
  • resolution set to fixed

It's an implicit remembering when the user clicked "Display images" within the current session. If the GET parameter '_safe' is set this is remembered in the session vars:

$_SESSION['safe_messages'][$MESSAGE['UID']] = true

As mentioned in the above comment this is not a persistent saving as suggested in #1484601.

P.S. And it works for me.

Changed 8 months ago by thomasb

...since r1046. Sorry guys!

Changed 8 months ago by till

Great! And I agree - #1484601 needs some thought and can wait.

Note: See TracTickets for help on using tickets.