Suggestion: Customization of tinyMCE

[seansan]

I changed the way tinyMCE works because i thought there are just too many buttons for this e-mail program (in current state). This probably my own taste here, but thought I'd share.

I changed two things

1. only 1 bar - to make it more common to use

@program: editor.js

function rcmail_editor_init(skin_path)
  {
  tinyMCE.init({ mode : 'specific_textareas',
                 accessibility_focus : false,
                 apply_source_formatting : true,
                 theme : 'advanced',
                 plugins : 'emotions,media,nonbreaking,table,searchreplace,spellchecker,visualchars',
                 theme_advanced_buttons1 : 'bold,italic,underline,separator,justifyleft,justifycenter,justifyright,justifyfull,separator,bullist,numlist,outdent,indent,separator,emotions,forecolor,backcolor,fontselect,fontsizeselect, separator,undo,redo,image,media',
                 theme_advanced_buttons2 : '',
                 theme_advanced_buttons3 : '',
                 theme_advanced_toolbar_location : 'top',
                 theme_advanced_toolbar_align : 'left',
                 font_size_classes : "fontSize1",
                 extended_valid_elements : 'font[face|size|color|style],span[id|class|align|style]',
                 content_css : skin_path + '/editor_content.css',
                 popups_css : skin_path + '/editor_popup.css',
                 editor_css : skin_path + '/editor_ui.css'
               });
  }

2. changed the default template to support default font (that it is actually readable) + make it better readable in received messages (not alligned directly to the top and left frame). Often when clicking backspace in an empty message brought the default font back to a very small font

@skins: editor_content.css

body, td, pre {
	font-family: Arial;
	font-size: 12px;
}

body {
	background-color: #FFFFFF;
	margin-left: 5px;
	margin-top: 1em;
}

[seansan]

Example

[seansan]

Example of how gmail does it - see the margins

[till]

I'm not a huge fan of HTML email anyway, so I got no "opinion" on this one, but for sure Sean's customization looks better.

Reply with +1 or -1, and we decide before 0.1-stable.

[xyanide]

1

[tomekp]

+1, but i would leave the html icon

[yllar]

i agree with tomekp

[estadtherr]

I originally chose to include the toolbar buttons for any kind of formatting that was "natively" supported by HTML, i.e. could be viewed/rendered in RoundCube's message viewer. Obviously there's quite a spectrum of personal preferences relative to how much formatting people like to have available when composing an e-mail message. The built-in "simple" theme in TinyMCE seemed too simple, but one can obviously go nuts with the formatting provided by the product. Although I hesitate to open it up for too much debate (given the almost innumerable number of configurations we could provide), we may be able to agree on a "Simple" vs. "Full" set of toolbar buttons, and allow it to be chosen as a preference.

I do like the margins, though, so I'll definitely add that and the font size to the trunk.

[till]

Assigning to Eric, since he is in the know.

[till]

Btw, I'd suggest we keep it rather simple.

For example - I hate tables in an E-Mail and so on. Just because something is doable, you shouldn't support it. As in, you can wreck your car on a tree, but should you do it? Probably not! :-D

I like the Google Approach and generally I am a big fan of the KISS (Keep It Simple, Stupid) principal.

[blodan]

while you guys are at it, might be a good idea to upgrade to tinymce 3.0-final at the same time

[estadtherr]

I guess I won't miss the HTML tables, so condensing the best of the remaining buttons down to one row (keeping the HTML popup) ended up keeping everything good.

I did notice that seansan removed the spellcheck button - is everyone ok with removing that? It would actually let us close a couple other tickets (forcing TinyMCE's spellcheck logic to use a custom URL was becoming troublesome anyway), and Firefox and Safari both already do spellchecking anyway.

[till]

+1 on removing the button, imo feel free to close!

[alec]

Closing, was fixed.