Opened 5 years ago

Closed 5 years ago

#1484710 closed Bugs (fixed)

Problems sending to multiple addresses without using address book.

Reported by: stever-corp Owned by: robin
Priority: 5 Milestone: 0.1-stable
Component: Client Scripts Version: git-master
Severity: normal Keywords:
Cc:

Description

When composing a new message to multiple recipients and typing in the recipients, an error is received when attempting to send the message. A javascript alert comes up and says "Please enter at least one recipient." The error occurs in Firefox 2.0.0.11 Win32 and IE7.

I have tried the following combinations of email addresses:

address1@email.com,address2@email.com
address1@email.com ,address2@email.com
address1@email.com, address2@email.com
address1@email.com , address2@email.com
address1@email.com;address2@email.com
address1@email.com ;address2@email.com
address1@email.com; address2@email.com
address1@email.com ; address2@email.com

Attachments (2)

#1484710.200802011152.patch (665 bytes) - added by robin 5 years ago.
Possible fix.
#1484710.200802011307.patch (4.3 KB) - added by robin 5 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 years ago by stever-corp

This also occurs with spaces and new lines separating the addresses.

SVN Info:

Path: .
URL: https://svn.roundcube.net/trunk/roundcubemail
Repository Root: https://svn.roundcube.net
Repository UUID: 208e9e7b-5314-0410-a742-e7e81cd9613c
Revision: 952
Node Kind: directory
Schedule: normal
Last Changed Author: tomekp
Last Changed Rev: 952
Last Changed Date: 2008-01-08 13:40:06 -0500 (Tue, 08 Jan 2008)

comment:2 Changed 5 years ago by thomasb

  • Milestone set to 0.1-stable

This is done by function rcube_check_email() in program/js/common.js

comment:3 Changed 5 years ago by robin

  • Owner set to robin
  • Status changed from new to assigned

RoundCube does not recognize this as recipient:

robin@…, robin@…

But it recognizes this:

<robin@…>, <robin@…>

And even this (which is weird):

<robin@…>, robin@…

Changed 5 years ago by robin

Possible fix.

comment:4 Changed 5 years ago by robin

#1484710.200802011152.patch contains a possible fix.

Though the expression is now still broken. For example it still allows:

address@…>, address@…

I propose to first split the recipient list using ',' and ';', and then check for valid addresses.

Changed 5 years ago by robin

comment:5 Changed 5 years ago by robin

#1484710.200802011307.patch first splits using ',' or ';', then checks the seperate addresses for validity. Also fixed the check that allowed 'address@…>' and such.

comment:6 Changed 5 years ago by till

@robin Please commit!

comment:7 Changed 5 years ago by thomasb

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [e581e741]

Note: See TracTickets for help on using tickets.