[PATCH] Re-opening a draft with text/plain attachment loses attachment

[tvk]

If you re-open a draft with a text/plain (in fact, any text/*) attachment, the attachment will not be displayed and is effectively lost. I can imagine that this problem will also occur when forwarding a message with text/plain attachments, but have not tested that.

Steps to reproduce:

1. Create a new message
   
2. Add recipients, subject, some mail text
   
3. Add one or more attachments of MIME type text/plain (just create a .txt file with your favourite editor)
   
4. Save the message as a draft ---> attachment is saved correctly (verified on IMAP server)
   
5. Go to the Drafts folder. The message will have an attachment paper clip symbol next to it.
   
6. Re-open the draft
   
7. The attachment is gone...
   

Fix:
The problem lies in roundcubemail/program/steps/mail/compose.inc:886. This if statement excludes all MIME parts of type text/* and message/* from being displayed as attachments. This is presumably done to make sure that no body part (text or html) will show up as an attachment. I would suggest instead to just check for the existence of a Content-Disposition: attachment or inline header in the MIME part. If there is one, the part should be displayed as an attachment.

Please see the attached patch against r921, which implements this.

[tvk]

patch to fix this, against r921

[thomasb]

Looks gut but needs so,e testing.

[till]

Discovered that if I add a single attachment, but no text, the attachment is also cut off - no matter which type. This bug is fixed in [8ecb0e8f].

On to the next bug in this ticket!

[till]

"Original" bug is fixed in [c3c0fb71].

Thanks for reporting this. ;-)