Opened 6 years ago
Closed 5 years ago
#1484627 closed Bugs (fixed)
MIME parsed incorrectly - patch available
| Reported by: | rasky@… | Owned by: | |
|---|---|---|---|
| Priority: | 5 | Milestone: | 0.2-alpha |
| Component: | MIME parsing | Version: | 0.1-rc1 |
| Severity: | normal | Keywords: | html multipart |
| Cc: |
Description
Starting from 0.1-rc1, Roundcube does not display correctly the attached mail. It looks like a regression in MIME parsing.
Attachments (2)
Change History (9)
Changed 6 years ago by rasky@…
comment:1 Changed 6 years ago by thomasb
- Component changed from Core functionality to MIME issue
- Keywords html multipart added
comment:2 Changed 5 years ago by rasky@…
This patch fixes the problem. Why is there a hardcoded "5" value? What is it for? There are many hardcoded indices for parts later in the same function...
Index: program/include/rcube_imap.inc
===================================================================
--- program/include/rcube_imap.inc (revision 903)
+++ program/include/rcube_imap.inc (working copy)
@@ -1054,7 +1054,8 @@ class rcube_imap
$struct->parts = array();
for ($i=0, $count=0; $i<count($part); $i++)
- if (is_array($part[$i]) && count($part[$i]) > 5)
+ if (is_array($part[$i]) /*&& count($part[$i]) > 5*/)
$struct->parts[] = $this->_structure_part($part[$i], ++$count, $struct->mime_id);
return $struct;
comment:3 Changed 5 years ago by prodigy7
I've the same problem and this fix solve this. Please apply this fix to the current svn version.
Thx
comment:4 Changed 5 years ago by zeridon
Confirmed, patch is working
version used: svn revision: 1049
attaching a sample mail ...
Changed 5 years ago by zeridon
Sample html mail which does not display in RC. Most of the headers are cut and part of info is obfuscated
comment:5 Changed 5 years ago by seansan
- Milestone set to 0.1.1
- Summary changed from MIME parsed incorrectly, no HTML mail displayed to MIME parsed incorrectly - patch available
Review in 0.1.1
comment:6 in reply to: ↑ description Changed 5 years ago by yitbos
Replying to rasky@develer.com:
Starting from 0.1-rc1, Roundcube does not display correctly the attached mail. It looks like a regression in MIME parsing.
This still is not part of the released version
comment:7 Changed 5 years ago by alec
- Resolution set to fixed
- Status changed from new to closed
Fixed in [cfe4a6ba].

Mail not displayed correctly