Ticket #1484627 (closed Bugs: fixed)

Opened 15 months ago

Last modified 7 months ago

MIME parsed incorrectly - patch available

Reported by: rasky@… Owned by:
Priority: 5 Milestone: 0.2-alpha
Component: MIME parsing Version: 0.1-rc1
Severity: normal Keywords: html multipart
Cc:

Description

Starting from 0.1-rc1, Roundcube does not display correctly the attached mail. It looks like a regression in MIME parsing.

Attachments

[DevTools] changes by batt for devtools (2007-09-04).eml (4.5 kB) - added by rasky@… 15 months ago.
Mail not displayed correctly
rc-sample-html-mail.txt (1.2 kB) - added by zeridon 11 months ago.
Sample html mail which does not display in RC. Most of the headers are cut and part of info is obfuscated

Change History

Changed 15 months ago by rasky@…

Mail not displayed correctly

  Changed 15 months ago by thomasb

  • keywords html multipart added
  • component changed from Core functionality to MIME issue

  Changed 14 months ago by rasky@…

This patch fixes the problem. Why is there a hardcoded "5" value? What is it for? There are many hardcoded indices for parts later in the same function...

Index: program/include/rcube_imap.inc
===================================================================
--- program/include/rcube_imap.inc      (revision 903)
+++ program/include/rcube_imap.inc      (working copy)
@@ -1054,7 +1054,8 @@ class rcube_imap

       $struct->parts = array();
       for ($i=0, $count=0; $i<count($part); $i++)
-        if (is_array($part[$i]) && count($part[$i]) > 5)
+        if (is_array($part[$i]) /*&& count($part[$i]) > 5*/)
           $struct->parts[] = $this->_structure_part($part[$i], ++$count, $struct->mime_id);

       return $struct;

  Changed 14 months ago by prodigy7

I've the same problem and this fix solve this. Please apply this fix to the current svn version. Thx

  Changed 11 months ago by zeridon

Confirmed, patch is working

version used: svn revision: 1049

attaching a sample mail ...

Changed 11 months ago by zeridon

Sample html mail which does not display in RC. Most of the headers are cut and part of info is obfuscated

  Changed 11 months ago by seansan

  • summary changed from MIME parsed incorrectly, no HTML mail displayed to MIME parsed incorrectly - patch available
  • milestone set to 0.1.1

Review in 0.1.1

in reply to: ↑ description   Changed 8 months ago by yitbos

Replying to rasky@develer.com:

Starting from 0.1-rc1, Roundcube does not display correctly the attached mail. It looks like a regression in MIME parsing.

This still is not part of the released version

  Changed 7 months ago by alec

  • status changed from new to closed
  • resolution set to fixed

Fixed in r1480.

Note: See TracTickets for help on using tickets.