Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#1484623 closed Feature Patches (fixed)

patch: adds support for the flagged/unflagged message column as config option

Reported by: seansan Owned by:
Priority: 5 Milestone: 0.2-beta
Component: Core functionality Version: 0.1-rc1
Severity: normal Keywords:
Cc:

Description

Hi there,

I have added the functionality to show the flagged/unflagged column for mail messages in the message listing - configurable in config/default set to FALSE. Attached you will find two new icons + the full patch against SVN 388. Also an example view. Tested ok.

I think is a welcome addition to RC and at least offers the functionality to show flagged messages (if desired by the admin via config).

TODO: (not now) functionality to set the message flag to flagged/unflagged from roundcube by event.

Attachments (8)

patch_add_flagged_column_svn388.zip​ (2.5 KB) - added by seansan 6 years ago.
patch and icons to add functionality
example.JPG​ (4.2 KB) - added by seansan 6 years ago.
Example of new functionality
patch_add_flagged_column_and_event_svn388.zip​ (4.0 KB) - added by seansan 6 years ago.
Version 2 - with backend event triggering and backend integration
patch_add_flagged_column_and_event_svn388.2.zip​ (4.0 KB) - added by seansan 6 years ago.
VERSION 3 - patch file 22 okt - fixed UNFLAGGING
patch_add_flagged_column_and_event_svn388_v4.zip​ (4.3 KB) - added by seansan 6 years ago.
VERSION 4 - patch file 8 nov - fixed column header renamin
patch_add_flagged_column_and_event_svn_r1142_v5.zip​ (10.9 KB) - added by RaphaelKa 5 years ago.
VERSION 5 - patched against current trunk - two fixes
patch_add_flagged_column_and_event_svn_r1170_v6.zip​ (4.8 KB) - added by RaphaelKa 5 years ago.
VERSION 6 - unflagging was broken for me, bugfixed and with other icon
patch_add_flagged_column_and_event_svn_r1256_v7.zip​ (4.9 KB) - added by RaphaelKa 5 years ago.
patched against revision 1256 (~ 0.1.1-stable) - minor fixes because of merge conflict

Download all attachments as: .zip

Change History (16)

Changed 6 years ago by seansan

patch and icons to add functionality

Changed 6 years ago by seansan

Example of new functionality

comment:1 follow-up: Changed 6 years ago by thomasb

  • Milestone changed from 0.1-rc2 to 0.1.1

Later.

Changed 6 years ago by seansan

Version 2 - with backend event triggering and backend integration

comment:2 in reply to: ↑ 1 Changed 6 years ago by seansan

Replying to thomasb:

Later.

OK. See updated patch with event trigger onclick to toggle icon and flag, also updates the IMAP backend

comment:3 Changed 6 years ago by seansan

See attachment DIFF : Version 2 - with backend event triggering and backend integration.

Updated patch with event trigger onclick to toggle icon and flag, also updates the IMAP backend

Changed 6 years ago by seansan

VERSION 3 - patch file 22 okt - fixed UNFLAGGING

Changed 6 years ago by seansan

VERSION 4 - patch file 8 nov - fixed column header renamin

Changed 5 years ago by RaphaelKa

VERSION 5 - patched against current trunk - two fixes

comment:4 Changed 5 years ago by seansan

See dupe #1484802 (also with patch)

Changed 5 years ago by RaphaelKa

VERSION 6 - unflagging was broken for me, bugfixed and with other icon

comment:5 Changed 5 years ago by RaphaelKa

appendix: also added some improvements (e.g. entries for marking toolbar menu) from #1484802

comment:6 Changed 5 years ago by till

  • Milestone changed from 0.1.1 to 0.2-beta

Changed 5 years ago by RaphaelKa

patched against revision 1256 (~ 0.1.1-stable) - minor fixes because of merge conflict

comment:7 Changed 5 years ago by alec

  • Resolution set to fixed
  • Status changed from new to closed

Patch with few modifications added in [e189a6ca].

comment:8 Changed 5 years ago by the_glu

You simply rox dude °o°

Note: See TracTickets for help on using tickets.