Opened 6 years ago

Closed 5 years ago

#1484605 closed Bugs (fixed)

roundcubemail-0.1-rc1.1 message list selection feature has an incremental bug

Reported by: RescuNET Owned by:
Priority: 5 Milestone: 0.1-stable
Component: Interface Version: 0.1-rc1
Severity: normal Keywords:
Cc:

Description

Scenario:

I select multiple messages in the message list using the keyboard SHIFT+DOWN 2nd selection iteration using the keyboard results in 2 messages selected for delete/move operation per SHIFT+DOWN
SHIFT+UP and delete/move them.
SHIFT+UP....

...

nth selection iteration using the keyboard results in n messages selected for delete/move operation per SHIFT+DOWN
SHIFT+UP.

Attachments (1)

1484605_2008_02_12.diff​ (1.0 KB) - added by gms8994 5 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 6 years ago by RescuNET

Sorry, Bug Report should be titled as incremental, not exponential.

comment:2 Changed 6 years ago by jpingle

  • Summary changed from roundcubemail-0.1-rc1.1 message list selection feature has an exponential bug to roundcubemail-0.1-rc1.1 message list selection feature has an incremental bug

Fixed title per user.

comment:3 Changed 6 years ago by thomasb

  • Milestone set to 0.1-stable

Can anybody confirm this with the latest trunk?

comment:4 Changed 6 years ago by seansan

Cannot reproduce.

Although with preview pane selections using the keyboard dont work altogether (IE6)

Also, when holding different combinations of SHIFT and CTRL has unexpected behavior.

  • When highlighting 1 message and using the UP keys to browse the list the selection moves upwards. When clicking up several times with the CTRL key pressed has no visual action. But then the next UP without CTRL selectes more than the expected messages up.
  • When selectig with SHIFt alone the messages are selected. Using upward or downward keys. When holding SHIFT + CTRL the user can select upwards + downwards

comment:5 Changed 6 years ago by RescuNET

Behavior is observed in MSIE 7.0.5730.11. Firefox 2.0.0.7 behaves correctly.

comment:6 Changed 5 years ago by thomasb

#1484632 marked as duplicate of this bug.

comment:7 Changed 5 years ago by till

Confirmed in IE7.

comment:8 Changed 5 years ago by gms8994

Confirmed in IE6.

I tried running this several times, and got up to 7 messages selected at once. After that, it threw an error:

Line: 403
Error: 'this.rows[...].obj' is null or not an object

It threw that error once for each message on the screen.

comment:9 Changed 5 years ago by gms8994

This problem is related to line 89 of list.js. The key_press event listener is being added multiple times, each time after you select a message.

comment:10 Changed 5 years ago by seansan

just tested in IE6 - cannot reproduce

comment:11 Changed 5 years ago by till

@seansan You may wanna try a pure IE6.

Changed 5 years ago by gms8994

comment:12 Changed 5 years ago by gms8994

Submitting patch (attached). IE allows (per ​MSDN) multiple listeners with the same event on an object, even if they have the same function. This patch detaches the listener before attaching.

comment:13 Changed 5 years ago by till

  • Resolution set to fixed
  • Status changed from new to closed

Thanks for this. It's fixed in [a265ab1a]!

Note: See TracTickets for help on using tickets.