Opened 6 years ago

Closed 5 years ago

#1484577 closed Feature Patches (fixed)

Received header not used when Date header is missing

Reported by: memoryhole Owned by: thomasb
Priority: 5 Milestone: 0.1-stable
Component: Client Scripts Version: git-master
Severity: normal Keywords:
Cc:

Description

Some email systems (such as the NYTimes.com email-article-to-a-friend service, and iTunes weekly mailings) do not have Date headers (an RFC nonconformity which is not corrected by qmail servers). Most mail reader programs compensate for emails that don't have Date headers by using the timestamp on the first Received header when the Date header is missing. Roundcube doesn't, and so emails without Date headers are sorted with a null date, so the show up in unexpected places in the lists of emails sorted by date.

Attachments (1)

bad_date_display.patch (1.5 KB) - added by memoryhole 6 years ago.
A fix for the display problem. Extracts the date field from the first-added Received header.

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by memoryhole

A fix for the display problem. Extracts the date field from the first-added Received header.

comment:1 Changed 6 years ago by thomasb

  • Milestone set to 0.1-stable
  • Owner set to thomasb
  • Status changed from new to assigned
  • Type changed from Bugs to Patches

We have to check carefully if INTERNALDATE always works for sorting.

comment:2 follow-up: Changed 6 years ago by thomasb

Also fetching the Received header causes a much higher data load. And this only to display non-conform mails. I don't know if this is worth it...

comment:3 in reply to: ↑ 2 Changed 6 years ago by memoryhole

Replying to thomasb:

Also fetching the Received header causes a much higher data load. And this only to display non-conform mails. I don't know if this is worth it...

Perhaps it would be better to only fetch the Received headers for messages without Date headers?

comment:4 Changed 5 years ago by till

  • Owner changed from thomasb to till
  • Status changed from assigned to new

Committed bad_date_display.patch in [90180eff].

I will split the 2nd patch into a feature request and delay it.

comment:5 Changed 5 years ago by till

  • Resolution set to fixed
  • Status changed from new to closed

Closing this, feature request in #1484769 (delayed to 0.1.1).

@memoryhole: Thanks for the patch, please reopen if this doesn't work!

comment:6 Changed 5 years ago by till

  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opened to revise the patch. ;-)

comment:7 Changed 5 years ago by till

Revision [d5ff9276] is my attempt to make it better, but it's not working yet - not sure why.

comment:8 Changed 5 years ago by till

  • Owner changed from till to thomasb
  • Status changed from reopened to new

Fixed by thomasb in [a9a8ef2b]! Thanks!

comment:9 Changed 5 years ago by till

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.