Problem with Signature in IE7

[skibi82]

On roundcubemail-trunk-r764-20070830.tgz Is problem with signature on IE7 in no added on write message On Firefox the signature is added

[robin]

Works for me. Please test against latest SVN.

[stever-corp]

Just tested against svn 947 and I am experiencing the problem.

Directions to reproduce:
Go to Personal Settings.
Double-click user's identitity.
Check HTML Signature.
Type in signature and save changes.
Go back into Personal Settings and ensure Compose HTML messages is selected.
Attempt to compose new signature and the signature is missing.

If the settings are set to not compose html messages the signature appears as text.

[seansan]

Works for me

Replying to stever-corp:

Just tested against svn 947 and I am experiencing the problem.

Directions to reproduce:
Go to Personal Settings.
Double-click user's identitity.
Check HTML Signature.
Type in signature and save changes.
Go back into Personal Settings and ensure Compose HTML messages is selected.
Attempt to compose new signature and the signature is missing.

If the settings are set to not compose html messages the signature appears as text.

[till]

I have a HTML signature, my compose-mode has tinyMCE as well. Signature is in identities and it's also correctly inserted into a message in Firefox (Mac, Windows) and Safari.

In IE7 I get, Object is 'null' or not an object., when I try to compose a new message. Not sure if it's related to the signature bug or any of the other tinyMCE obstacles we are facing.

It breaks in program/js/app.js:

...
var editor = tinyMCE.getInstanceById(eid);
var msgDoc = editor.getDoc();
...

Specifically it dies at editor.getDoc().

[till]

Assigning to Eric so he can take care of the TinyMCE issue.

[till]

r1040 fixes the error I reported.

Signature in IE7 is still MIA.

[till]

Changing Firefox in the description. ;-) (Just had to.)

[estadtherr]

I haven't been able to repeat any signature issues with IE 7.0.5730.11, even changing identities and all combinations of the HTML compose/signature settings. I recommend closing this "worksforme" unless someone can come up with a set of steps.

[lancey]

This bug still exists in SVN v1111. Steps to reproduce: 1. Edit your identity - use HTML signature, add this html for signature: <span style="color: #cccccc"> <hr /> test signature</span> 2. Compose a new message with HTML compose mode selected as default - the signature is not added.

This is with IE 7.0.5730.11, the very same signature works okay in Firefox 2.0.0.12. The signature is also not added by IE7 when replying to messages, too.

[lancey]

Also, I get a JS error in IE7 when trying to reply to a message: Line: 3585 Char: 5 Error: Can't move focus to the control because it is invisible, not enabled, or of a type that does not accept the focus. Code: 0

[sibra]

Replying to skibi82:

On roundcubemail-trunk-r764-20070830.tgz Is problem with signature on IE7 in no added on write message On Firefox the signature is added

hi guys. this seems to be a serious problem in IE6/IE7. some details: if you activate "Compose HTML Messages" in the user preferences and switch to the "Create a new Message" screen, then the editor doesn't load the signature. But, if this option isn't checked, and you manually switch from Text to HTML, then it gets loaded.

i updated from rc1 to the latest nightly build http://nightly.roundcube.net/trunk/roundcubemail-trunk-r1045-20080211.tgz

and at /js/app.js, Line 1835, somebody added these lines:

if (editor == null) {
    return false;
}

but thats not more than just a hack to avoid the IE script error because it still doesn't work. is anybody on the run to fix this problem?

[estadtherr]

I fixed the delayed initialization logic that was supposed to be loading the signature after the page was rendered. It turns out that calling "setTimeout(func, millis)" does not actually set a timer on IE - the function executes immediately. One must use "window.setTimeout(func, millis)". I fixed this in the call_init function in program/js/app.js (and other places where the bare reference appeared in that file). Also, it appears that the 200 millisecond delay is not sufficient on Windows to make the initialization happen after the page loads (it's sufficient on other platforms). I changed it to up the delay to 500 milliseconds if the browser is running on Windows.