r673 Does Not Work with PHP 4

[brian]

I updated to the latest SVN r673. It works fine on PHP 5, but does not work on PHP 4. The problem is the new mbstring detection in program/include/main.inc @ line 478. It appears the extension_loaded("mbstring") was an attempt to prevent the error, however, mb_list_encoding() is a PHP 5 only command. On my PHP 4 server, the extension_loaded("mbstring") returns a "1", making the latest SVN fail on PHP 4.

I have a fix for this issue, though it may not be the ideal fix, this did resolve my problem...

Original Line 475:

  if (is_null($s_mbstring_loaded) && ($s_mbstring_loaded = extension_loaded("mbstring")))

Modified Line 475:

  if (is_null($s_mbstring_loaded) && ($s_mbstring_loaded = extension_loaded("mbstring")) && (substr(phpversion(),0,1) == "5"))

Yep, that's right. It just checks the major version of PHP to make sure it's 5.

[thomasb]

Fixed in trunk [88f66ec8]