Preview Pane not Working

[Arrmo]

Hi,

I may just have something messed up, but it seems like the Preview Pane is no longer working. Is this by design?

[tnf]

Same for me after a fresh install of 0.1-rc1. I tried copying the old preview settings as follows:

// Enable preview pane
$rcmail_config['enable_preview'] = TRUE;
$rcmail_config['preview_pane'] = TRUE;

// display preview pane if enabled
$rcmail_config['preview'] = TRUE;

But it doesn't matter if those settings are there or not, the preview pane never shows.

[mtu]

The preview pane is not included in 0.1rc.

[Arrmo]

Hi,

Is it still in the SVN (as I'd rather use a buggy version with preview than a clean version without ... :-()?

Thanks!

[tnf]

Would have been nice to mention the removal of the preview in the release notes or the changelog as I surely wouldn't have upgraded had I known this... In the changelog are even some bugfixes regarding the preview pane?!?

[thomasb]

Well, the release notes are for those upgrading from 0.1-beta or beta2. As you can see on the roadmap, the preview pane is scheduled for later.

[tnf]

Here is a way to enable the preview pane. I'm not a roundcube developer, it just seems to work for me...

In program/steps/settings/func.inc, line 172 remove

false &&

so that the line looks like this

if (!isset($no_override['preview_pane']))

In skins/default/templates/mail.html, line 7 add

<script type="text/javascript" src="/splitter.js"></script>

so that the lines 6-8 look like this:

<link rel="stylesheet" type="text/css" href="/mail.css" />
<script type="text/javascript" src="/splitter.js"></script> 
</head>

In the same file, line 58 add

<roundcube:if condition="config:preview_pane == true" />
<script type="text/javascript">
  var mailviewsplit = new rcube_splitter({id:'mailviewsplitter', p1: 'mailcontframe', p2: 'mailpreviewframe', orientation: 'h'});
  rcmail.add_onload('mailviewsplit.init()');
</script>
<div id="mailpreviewframe">
<roundcube:object name="messagecontentframe" id="messagecontframe" width="100%" height="100%" frameborder="0" src="/watermark.html" />
</div>

<style type="text/css">
#mailcontframe {
  bottom: auto;
  height: 208px;
}
</style>
<roundcube:endif />

between

</div>

and

<div id="listcontrols"> 

In /config/main.inc.php, append

// Enable preview pane
$rcmail_config['enable_preview'] = TRUE;
$rcmail_config['preview_pane'] = TRUE;

// display preview pane if enabled
$rcmail_config['preview'] = TRUE;

Download http://trac.roundcube.net/trac.cgi/browser/trunk/roundcubemail/skins/default/splitter.js?rev=412&format=raw and store it in /skins/default

Good luck

[kbyrd]

A comment and a question.

1) Removing the preview pane without warning was pretty bad. I know (now) that it's in te roadmap, but it's reasonable to expect users don't read roadmaps unless they want to know when a future feature is coming. Many users simply see the news item for an upgrade, see: 0.1-beta (or nightly-20070318) vs. 0.1-rc1 then look at release or installation notes to see if it will be hard. I wouldn't always exepect going from beta to rc1 would add features, it should at least be more stable, but no one expects moving from beta to rc1 to actually remove a feature. I guess I have to be involved in the forums to be even a casual roundcube user.

2) tnf: How's that patch working? Any side effects? Can the developers comment why preview pane was disabled for 0.1? I understand that if I use the patch to turn it back on, I'm on my own, but I'd like a bit of guidance before I do that.

[tnf]

The patch still works for me, didn't have any problems yet. Still, no guarantees on that as I know only very little about the roundcube code

[jaimeco]

On version roundcubemail-0.1-rc2 those patches are included, except

/config/main.inc.php

---

// Enable preview pane $rcmail_configenable_preview? = TRUE; $rcmail_configpreview_pane? = TRUE;

// display preview pane if enabled $rcmail_configpreview? = TRUE;

---

although, preview pane doesn't work, the options was enabled when I change the followind line in program/steps/settings/func.inc, line 172.

if (!isset($no_overridepreview_pane?)) by

if (isset($no_overridepreview_pane?))

When I modify that, in preferences menu shows the preview pane option. then it works now. Sorry about my english.