Ticket #1484388 (closed Bugs: worksforme)

Opened 3 years ago

Last modified 3 years ago

weird select behavior in message list

Reported by: maharaja Owned by:
Priority: 5 Milestone: 0.1-rc2
Component: Interface Version: 0.1-rc1
Severity: normal Keywords: select message list
Cc:

Description

hi!

in contrast to the prior 0.1-beta2 i notice the following behavior in the message list, that clicking on a message subject does not properly select the message:

e.g. * clicking the message subject highlights the message. clicking delete once make the "selected bar" grey. clicking a second time deletes the message * using shift to select some messages opens a new window with the last clicked message. the message list remembers the pressed shift key - even if its not pressed anymore so deleting gets permanent * using control to select some messages opens a new tab-window with the clicked messages. delete seems to work as exptected.

my browser is firefox 2.0.0.3

please have a look into this bug - maybe it is related and/or interdependent to #1484387 ? :)

Change History

Changed 3 years ago by phs

* clicking the message subject highlights the message. clicking delete once make the "selected bar" grey. clicking a second time deletes the message

i use rc1 as well, but this works for me...

* using shift to select some messages opens a new window with the last clicked message. * using control to select some messages opens a new tab-window with the clicked messages.

this only seems to be an issue with firefox, because in rc1 the emails in the message list became normal links and firefox opens links in a new window, when shift is pressed resp. opens links in a new tab, when ctrl is pressed. is there any workaround? delete works for me in both cases as expected.

Changed 3 years ago by genezys

There is a "return false" in the "onclick" event of the link. This is not enough to block the browser from activating the link according to DOM specification.

You have to call preventDefault() on the event object passed in parameter to the function responding to the event. Unfortunately, this is impossible using inline event syntax, you have to attach the handler using DOM.

Here is a sample page that works OK in Firefox & Internet Explorer 

<html>
<head>
<script type="text/javascript">
function onClick(event)
{
	// IE does not pass the argument but use window.event instead
	event = window.event || event; 	

	// Call preventDefault if it exists
	if( event.preventDefault )
	{
		event.preventDefault();
	}
	return false;
}

window.onload = function()
{
	var a = document.getElementById("plop");
	a.onclick = onClick;
}
</script>
</head>

<body>
<p><a id="plop" href="http://google.fr">Plop</a></p>
</body>
</html>

Changed 3 years ago by thomasb

  • status changed from new to closed
  • resolution set to worksforme

Works for me. Tested with FF 2.0.0.3 on Mac. The shift/control click problem was solved in r586.

Changed 3 years ago by genezys

Works for me too using the latest SVN version.

Tested on Firefox 2.0.0.3 XP SP2.

Thanks :)

Note: See TracTickets for help on using tickets.