Ticket #1484383 (closed Patches: fixed)

Opened 16 months ago

Last modified 12 months ago

Missing translation in compose new email

Reported by: moc Owned by:
Priority: 1 Milestone: 0.1-rc2
Component: Interface Version: svn-trunk
Severity: normal Keywords:
Cc:

Description

In the file /skins/default/templates/compose.html the two labels Cc and Bcc are not translated. Here is the patch:

<td class="add-button"><a href="#" onclick="return rcmail_toggle_display('compose-cc')">[<roundcube:label name="cc" />]</a><br />
<a href="#" onclick="return rcmail_toggle_display('compose-bcc')">[<roundcube:label name="bcc" />]</a><br /></td>

Change History

Changed 12 months ago by robin

That's not a patch, that's modified original code :)

Anyway, I made the change, but the most-right <td> elements are set at 40px, which isn't enough for the dutch translation at least. The elements' width should be set automatically, but in my Firefox the textarea overlaps the text. So this needs more work.

Index: skins/default/templates/compose.html
===================================================================
--- skins/default/templates/compose.html	(revision 803)
+++ skins/default/templates/compose.html	(working copy)
@@ -63,8 +63,8 @@
 
 <td class="title top"><label for="rcmcomposeto"><roundcube:label name="to" /></label></td>
 <td><roundcube:object name="composeHeaders" part="to" form="form" id="rcmcomposeto" cols="80" rows="2" tabindex="2" /></td>
-<td class="add-button"><a href="#" onclick="return rcmail_toggle_display('compose-cc')">[Cc]</a><br />
-<a href="#" onclick="return rcmail_toggle_display('compose-bcc')">[Bcc]</a><br /></td>
+<td class="add-button"><a href="#" onclick="return rcmail_toggle_display('compose-cc')">[<roundcube:label name="cc" />]</a><br />
+<a href="#" onclick="return rcmail_toggle_display('compose-bcc')">[<roundcube:label name="bcc" />]</a><br /></td>
 
 </tr><tr id="compose-cc">
 
Index: skins/default/mail.css
===================================================================
--- skins/default/mail.css	(revision 803)
+++ skins/default/mail.css	(working copy)
@@ -785,7 +785,7 @@
 
 #compose-headers td.add-button
 {
-  width: 40px !important;
+  width: 60px !important;
   text-align: right;
   vertical-align: bottom;
 }

Changed 12 months ago by thomasb

  • status changed from new to closed
  • resolution set to fixed

Implemented a slightly different solution with new texts but this issue is considered to be fixed in r816.

Note: See TracTickets for help on using tickets.