needless try to autodetect mail header delimiter
|Reported by:||lespocky@…||Owned by:|
|Severity:||minor||Keywords:||delimiter rfc 2822|
RFC 2822 says explicitly that the delimiter for lines in e-mail should be CRLF, which is ASCII code 13 with directly following code 10. In 0.1beta2 in file program/steps/mail/sendmail.inc there is the following part:
// try to autodetect operating system and use the correct line endings // use the configured delimiter for headers if (!empty($CONFIG['mail_header_delimiter'])) $header_delm = $CONFIG['mail_header_delimiter']; else if (strtolower(substr(PHP_OS, 0, 3)=='win')) $header_delm = "\r\n"; else if (strtolower(substr(PHP_OS, 0, 3)=='mac')) $header_delm = "\r\n"; else $header_delm = "\n";
This is needless since $CONFIG['mail_header_delimiter'] can be hardcoded as chr(13).chr(10)
I don't know in which places this occurs at all, so please fix this everywhere else it occurs.