Opened 6 years ago
Closed 6 years ago
#1484277 closed Bugs (worksforme)
Footer gets inserted at the wrong place
| Reported by: | dasjoen | Owned by: | |
|---|---|---|---|
| Priority: | 1 - Highest | Milestone: | |
| Component: | PHP backend | Version: | git-master |
| Severity: | normal | Keywords: | |
| Cc: |
Description
In rcube_shared.inc, line 217, the output is converted to lowercase to find the last occurrence of </body> or </html>. The footer is then inserted at this position in the original output string.
The problem is that the position in the lowercase string is different from the original, perhaps because of some Unicode issue. This leads to a javascript being inserted at the wrong place in the compose form (in the middle of </script>), making it impossible to send mail.
The quick and dirty solution is to insert some extra line feeds before </body> in skins/default/templates/compose.html
Fixing it probably involves ditching strrstr() and using regular expressions in stead.
Attachments (1)
Change History (4)
comment:1 Changed 6 years ago by thomasb
- Severity changed from critical to normal
comment:2 Changed 6 years ago by dasjoen
Strange. Tried copying the original compose.html back, and now it works for me too...
The only thing I have done afterwards was editing some addresses in the address book with wrong characters in them.
Probably those were responsible for breaking it, but I have no way of testing this anymore...
comment:3 Changed 6 years ago by thomasb
- Resolution set to worksforme
- Status changed from new to closed
Cannot reproduce with latest version.
Changed 4 years ago by ldeviator
this came up for me... I'm really not sure what's causing it, but here's what I did to fix it
Works for me...