Ticket #1484277 (closed Bugs: worksforme)

Opened 21 months ago

Last modified 17 months ago

Footer gets inserted at the wrong place

Reported by: dasjoen Owned by:
Priority: 1 - Highest Milestone:
Component: PHP backend Version: svn-trunk
Severity: normal Keywords:
Cc:

Description

In rcube_shared.inc, line 217, the output is converted to lowercase to find the last occurrence of </body> or </html>. The footer is then inserted at this position in the original output string.

The problem is that the position in the lowercase string is different from the original, perhaps because of some Unicode issue. This leads to a javascript being inserted at the wrong place in the compose form (in the middle of </script>), making it impossible to send mail.

The quick and dirty solution is to insert some extra line feeds before </body> in skins/default/templates/compose.html

Fixing it probably involves ditching strrstr() and using regular expressions in stead.

Change History

Changed 21 months ago by thomasb

  • severity changed from critical to normal

Works for me...

Changed 21 months ago by dasjoen

Strange. Tried copying the original compose.html back, and now it works for me too...

The only thing I have done afterwards was editing some addresses in the address book with wrong characters in them.

Probably those were responsible for breaking it, but I have no way of testing this anymore...

Changed 17 months ago by thomasb

  • status changed from new to closed
  • resolution set to worksforme

Cannot reproduce with latest version.

Note: See TracTickets for help on using tickets.