Ticket #1484187 (closed Patches: fixed)

Opened 4 years ago

Last modified 3 years ago

Preview pane height incorrect in Safari & Konquerer

Reported by: brian Owned by:
Priority: 5 Milestone: 0.2-beta
Component: Client Scripts Version: svn-trunk
Severity: normal Keywords: preview pane height css safari
Cc:

Description

I found that I had to tweak the CSS code for the preview pane to display properly in Safari. (This is when using the latest svn code: r432).

Line: 144-151, /skins/default/mail.css

/*\*/
html>body*#messagecontframe
{
  [height: 40%;
  height: 54%;
  ]height: 100%;
}
/**/

I changed the value on line 148 from 40% to 54%. This adjustment was a perfect fit for the preview pane on Safari for me. I am running 10.4.8. Safari 2.0.4. Has anyone else seen this issue? According to the information in trac changeset r406, the middle value only applies to Safari, so I do not expect that it would break anything else.

Change History

  Changed 4 years ago by robin

On the old eMac I have here the preview pane is too large with 54%. We need another solution for Safari.

  Changed 4 years ago by robin

How is this:

Index: skins/default/mail.css
===================================================================
--- skins/default/mail.css      (revision 436)
+++ skins/default/mail.css      (working copy)
@@ -129,6 +129,7 @@
   bottom: 40px;
   border: 1px solid #999999;
   background-color: #F9F9F9;
+  overflow: auto;
   /* css hack for IE */
   width: expression((parseInt(document.documentElement.clientWidth)-240)+'px');
   height: expression((parseInt(document.documentElement.clientHeight)-135-document.getElementById('mailcontframe').offsetHeight)+'px');
@@ -145,7 +146,7 @@
 html>body*#messagecontframe
 {
   [height: 40%;
-  height: 40%;
+  height: 100%;
   ]height: 100%;
 }
 /**/

  Changed 4 years ago by robin

Hmm, that does funny things on my Mac Mini. The first previewed message gets overwritten with the background image after being displayed for a split-second, the second one is OK, a third one, if the message is larger than the second one, creates a new slider inside the iframe.

Need another solution :(

  Changed 4 years ago by brian

The issue is related to the dynamic resizing of the preview pane area. In Safari, it doesn't resize properly. This is why my percentage didn't work for you... I had forgotten that I had resized my preview pane.

  Changed 4 years ago by jpingle

  • milestone changed from 0.1-rc1 to 0.2-beta

  Changed 3 years ago by jpingle

  • summary changed from Safari Preview pane height incorrect to Preview pane height incorrect in Safari & Konquerer

As referenced in #1484519 this is also affecting Safari 3 beta and Konquerer.

  Changed 3 years ago by robin

Following change fixes this for Safari 3.0.3 on win32. I'm waiting for access to a Mac to see what it does there.

Index: skins/default/mail.css
===================================================================
--- skins/default/mail.css      (revision 803)
+++ skins/default/mail.css      (working copy)
@@ -145,7 +145,7 @@
 html>body*#messagecontframe
 {
   [height: 40%;
-  height: 40%;
+  height: 100%;
   ]height: 100%;
 }
 /**/

follow-up: ↓ 9   Changed 3 years ago by robin

In konqueror 3.5.6 it works too, except that the watermark overwrites the message preview, but it seems that problem was there before this change. In the mean time I'm still waiting for access to a Mac here... :)

in reply to: ↑ 8   Changed 3 years ago by robin

Replying to robin:

In the mean time I'm still waiting for access to a Mac here... :)

No, not on the Mac (Safari 2).

  Changed 3 years ago by robin

  • status changed from new to closed
  • resolution set to fixed

Fixed in SVN807.

Note: See TracTickets for help on using tickets.