RoundCube steals focus in app.js

[David Adam <zanchey@…>]

Some users have complained that RoundCube steals focus from other applications when an operation completes.

This is due to line 178 of app.js (in revision 358):

177         // focus this window
178         window.focus();

There is a school of thought which says that acquiring focus for anything except system-critical events is inelegant UI. I would like to suggest that RoundCube avoids grabbing focus unless absolutely essential, by removing lines 177-178.

[seansan]

Decide in 1.1 (fix/close)

[till]

Hehehe... We are so evil. :P

[till]

Unless someone supplies a patch, I'll postpone it!

[tensor]

Replying to till:

Unless someone supplies a patch, I'll postpone it!

There are several places where RC grabs focus. Shall the patch just remove them?

[robin]

RoundCube only grabs focus in one place (app.js), but there are 14 occurances of window.focus() in tiny_mce. I think we can keep them.

Index: program/js/app.js
===================================================================
--- program/js/app.js   (revision 1811)
+++ program/js/app.js   (working copy)
@@ -214,12 +214,6 @@

         this.set_page_buttons();

-        // focus main window
-        if (this.env.framed && window.parent)
-          window.parent.focus();
-        else
-          window.focus();
-
         // init message compose form
         if (this.env.action=='compose')
           this.init_messageform();

[robin]

Fixed in r1820.