Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#1484055 closed Feature Patches (fixed)

Error in JS with firebug - easy fix

Reported by: moxley Owned by:
Priority: 5 Milestone: 0.1-stable
Component: Client Scripts Version: 0.1-beta
Severity: normal Keywords:
Cc:

Description

Firebug is a powerful web development extension for Firefox that I highly recommend. When Firebug is installed, most of Roundcube's functionality doesn't work. I haven't pinpointed excactly where the primary conflict is, but I notice that Roundcube defines a function called console(). Firebug defines 'console.log()', so there's one conflict.

Attachments (1)

firebugok.jpg (80.3 KB) - added by lancey 5 years ago.
Roundcube works completely okay with Firebug enabled now.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by moxley

Found the fix: In line 3825 (0.1beta2) of program/js/app.js:
Change this: this.xmlhttp.open('GET', url);
To this: this.xmlhttp.open('GET', url, true);

Apparently, the 'asynchronous' flag needs to be explicitly set. Don't know why it only happens with Firebug.

comment:2 Changed 5 years ago by seansan

  • Milestone set to 0.1.1
  • Summary changed from Doesn't work with Firebug to Error in JS with firebug - easy fix
  • Type changed from Bugs to Patches

Line is 3661 in app.js

Changed 5 years ago by lancey

Roundcube works completely okay with Firebug enabled now.

comment:3 Changed 5 years ago by lancey

Not an issue anymore in SVN v1102, tested with Firefox 2.0.0.12 and Firebug 1.05, everything in Rouncube works just as expected, only a bit slower because of Firebug activity (normal behaviour for all sites when Firebug is enabled).

comment:4 Changed 5 years ago by yllar

  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 5 years ago by till

  • Milestone changed from 0.1.1 to 0.1-stable

On a sidenote - if a debugging tool breaks an app, please disable it.

Note: See TracTickets for help on using tickets.