"Move mail to trash" button does not work anymore after SVN r354

[Voyageur]

When viewing a mail in latest SVN (currently at r356), the "Move mail to trash" button does not work anymore: clicking it just adds a '#' at the end of the URL. Going back to inbox, the button works again and deletes the mail.

This appeared in r354 "Partial client re-write with a common list class" revision of SVN

[Voyageur]

Just noted, the "Move to" box does not work anymore either (trying to move a mail from inbox to another folder)

[lancey]

this.message_list doesn't get initialized at all.
If you paste this:
if (this.message_list == null) alert("no such object");
in your javascript console, it will show up there's no such object. I also see list.js is not included, and it defines the get_selection function which the Delete / move functions are using.
Something has gone wrong, but I'm not familiar enough with roundcube to fix that at this point.

[lancey]

OK, i suppose we SHOULDN'T have message_list at all when viewing a mail. The functions should affect the current message and not use the list functions at all.

[lancey]

Here's a fix for this bug:
Open the app.js file, and replace each occurence of:

 var selection = this.message_list.get_selection();

with

 var selection = 0;
 if (this.message_list != null) 
 {
  selection = this.message_list.get_selection();
 }

I will attach a patch soon.

[lancey]

Fixes delete/move while viewing message

[lancey]

SVN r359 file, with patch applied

[lancey]

Let someone review this and to SVN if the fix is appropriate.

[Voyageur]

Should not be closed as closed until fixed in SVN (or marked worksforme either, since a patch IS needed)

[Steltek]

It looks as if a fix for this has finally entered SVN.

[darren1234]

It seems to be partially fixed between SVN 360 and 372. The client script no longer fails, and the message does get removed.

But, when you click on the delete button nothing "appears" to happen. Well it does say "Loading..." then you return to viewing the message that was just deleted. You have no idea what, if anything has happened. Clicking on the delete button multiple times does not change the behavior.

It does delete the message, but the user has no idea it happened.

Returning to the message list after clicking on the delete button may be a better response.

[Voyageur]

And it's completely broken again as of [b6677bf9] ;)

[thomasb]

Fixed in Trunk [53ed1e32]