Ticket #1484007 (closed Patches: fixed)

Opened 4 years ago

Last modified 4 years ago

Quota is not correctly displayed after deleting mail

Reported by: wobin Owned by: robin
Priority: 5 Milestone:
Component: Interface Version: 0.1-beta
Severity: major Keywords: quota display
Cc:

Description

Since the implementation of the quota image the quota is not displayed correctly after deleting a message. This hack fixes that, but a better patch needs to be made to be sure array('display'=>true) is correct.

Index: program/steps/mail/move_del.inc
===================================================================
--- program/steps/mail/move_del.inc     (revision 340)
+++ program/steps/mail/move_del.inc     (working copy)
@@ -73,7 +73,7 @@
 if ($_action=='moveto')
   $commands .= sprintf("this.set_unread_count('%s', %d);\n", $_GET['_target_mbox'], $IMAP->messagecount($_GET['_target_mbox'], 'UNSEEN'));

-$commands .= sprintf("this.set_quota('%s');\n", $IMAP->get_quota());
+$commands .= sprintf("this.set_quota('%s');\n", rcmail_quota_display(array('display'=>true)));

 // add new rows from next page (if any)
 if ($_GET['_from']!='show' && $pages>1 && $IMAP->list_page < $pages)
Index: program/steps/mail/check_recent.inc
===================================================================
--- program/steps/mail/check_recent.inc (revision 340)
+++ program/steps/mail/check_recent.inc (working copy)
@@ -35,7 +35,7 @@
       $commands .= sprintf("this.set_unread_count('%s', %d);\n", addslashes($mbox_name), $unread_count);
       $commands .= sprintf("this.set_env('messagecount', %d);\n", $count);
       $commands .= sprintf("this.set_rowcount('%s');\n", rcmail_get_messagecount_text());
-      $commands .= sprintf("this.set_quota('%s');\n", $IMAP->get_quota());
+      $commands .= sprintf("this.set_quota('%s');\n", rcmail_quota_display(array('display'=>true)));

       // add new message headers to list
       $a_headers = array();

Change History

Changed 4 years ago by wobin

  • owner set to wobin
  • status changed from new to assigned

Changed 4 years ago by wobin

  • type changed from Bugs to Patches

Changed 4 years ago by ericliang

Is this bug related to the fact that sometimes quota image shows "Array" instead of the actual image?

Changed 4 years ago by wobin

Yes ericliang, that's the one :)

Changed 4 years ago by robin

  • owner changed from wobin to robin
  • status changed from assigned to new

Changed 4 years ago by robin

  • status changed from new to assigned

Changed 4 years ago by robin

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in SVN 414.

Note: See TracTickets for help on using tickets.