Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#1483930 closed Feature Patches (fixed)

Wrong tooltip for message browse buttons

Reported by: mtu Owned by: thomasb
Priority: 5 Milestone: 0.1-rc1
Component: Interface Version: 0.1-beta
Severity: trivial Keywords: tooltip
Cc:

Description

When hovering over the two little arrows in the bottom right corner of the message display, the tooltip for them says "Show next/previous set of messages" instead of "Show next/previous message".

Change History (4)

comment:1 Changed 8 years ago by mtu

patch submitted, waiting for commit

comment:2 Changed 8 years ago by mtu

  • Owner set to mtu
  • Priority changed from 3 to 5
  • Status changed from new to assigned
  • Type changed from Bugs to Patches

This fixes the wrong tooltip by referencing a new one called '{next,previous}message' instead of '{next,previous}messages':

diff -uNr rc-294/skins/default/templates/message.html rc-294fix/skins/default/templates/message.html
--- rc-294/skins/default/templates/message.html 2006-08-06 15:51:29.000000000 +0200
+++ rc-294fix/skins/default/templates/message.html      2006-08-06 17:26:15.000000000 +0200
@@ -11,9 +11,9 @@
 <roundcube:include file="/includes/header.html" />
 
 <div id="messagecountbar">
-<roundcube:button command="previousmessage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previousmessages" />
+<roundcube:button command="previousmessage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previousmessage" />
 &nbsp;<roundcube:object name="messageCountDisplay" />&nbsp;
-<roundcube:button command="nextmessage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextmessages" />
+<roundcube:button command="nextmessage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextmessage" />
 </div>
 
 <div id="messagetoolbar">

This is the standard translation (en_US) for this new label:

diff -uNr rc-294/program/localization/en_US/labels.inc rc-294fix/program/localization/en_US/labels.inc
--- rc-294/program/localization/en_US/labels.inc        2006-08-06 17:09:45.000000000 +0200
+++ rc-294fix/program/localization/en_US/labels.inc     2006-08-06 16:58:43.000000000 +0200
@@ -98,7 +98,9 @@
 $labels['deletemessage']    = 'Move message to trash';
 $labels['printmessage']     = 'Print this message';
 $labels['previousmessages'] = 'Show previous set of messages';
+$labels['previousmessage']  = 'Show previous message';
 $labels['nextmessages']     = 'Show next set of messages';
+$labels['nextmessage']      = 'Show next message';
 $labels['backtolist']       = 'Back to message list';
 $labels['viewsource']       = 'Show source';

And here are some more translations:

diff -uNr rc-294/program/localization/en_GB/labels.inc rc-294fix/program/localiz                                                                                   ation/en_GB/labels.inc
--- rc-294/program/localization/en_GB/labels.inc        2006-08-06 15:51:20.0000                                                                                   00000 +0200
+++ rc-294fix/program/localization/en_GB/labels.inc     2006-08-06 16:56:16.0000                                                                                   00000 +0200
@@ -99,7 +99,9 @@
 $labels['deletemessage']    = 'Move message to trash';
 $labels['printmessage']     = 'Print this message';
 $labels['previousmessages'] = 'Show previous set of messages';
+$labels['previousmessage']  = 'Show previous message';
 $labels['nextmessages']     = 'Show next set of messages';
+$labels['nextmessage']      = 'Show next message';
 $labels['backtolist']       = 'Back to message list';
 $labels['viewsource']       = 'Show source';

diff -uNr rc-294/program/localization/de_CH/labels.inc rc-294fix/program/localization/de_CH/labels.inc
--- rc-294/program/localization/de_CH/labels.inc        2006-08-06 15:51:22.000000000 +0200
+++ rc-294fix/program/localization/de_CH/labels.inc     2006-08-06 17:15:07.000000000 +0200
@@ -99,7 +99,9 @@
 $labels['deletemessage']    = 'In den Papierkorb verschieben';
 $labels['printmessage']     = 'Diese Nachricht drucken';
 $labels['previousmessages'] = 'Vorherige Nachrichten anzeigen';
-$labels['nextmessages']     = 'Weitere Nachrichten anzeigen';
+$labels['previousmessage']  = 'Vorherige Nachricht anzeigen';
+$labels['nextmessages']     = 'Folgende Nachrichten anzeigen';
+$labels['nextmessage']      = 'Folgende Nachricht anzeigen';
 $labels['backtolist']       = 'Zurück zur Liste';
 
 $labels['select'] = 'Auswählen';
diff -uNr rc-294/program/localization/de_DE/labels.inc rc-294fix/program/localization/de_DE/labels.inc
--- rc-294/program/localization/de_DE/labels.inc        2006-08-06 15:51:20.000000000 +0200
+++ rc-294fix/program/localization/de_DE/labels.inc     2006-08-06 17:03:49.000000000 +0200
@@ -100,7 +100,9 @@
 $labels['deletemessage']    = 'In den Papierkorb verschieben';
 $labels['printmessage']     = 'Diese Nachricht drucken';
 $labels['previousmessages'] = 'Vorherige Nachrichten anzeigen';
-$labels['nextmessages']     = 'Weitere Nachrichten anzeigen';
+$labels['previousmessage'] =  'Vorherige Nachricht anzeigen';
+$labels['nextmessages']     = 'Folgende Nachrichten anzeigen';
+$labels['nextmessage']     =  'Folgende Nachricht anzeigen';
 $labels['backtolist']       = 'Zurück zur Liste';
 
 $labels['select'] = 'Auswählen';

diff -uNr rc-294/program/localization/es/labels.inc rc-294fix/program/localization/es/labels.inc
--- rc-294/program/localization/es/labels.inc   2006-08-06 15:51:22.000000000 +0200
+++ rc-294fix/program/localization/es/labels.inc        2006-08-06 17:05:28.000000000 +0200
@@ -103,7 +103,9 @@
 $labels['deletemessage']    = 'Mover mensaje a la papelera';
 $labels['printmessage']     = 'Imprimir este mensaje';
 $labels['previousmessages'] = 'Mostrar mensajes anteriores';
+$labels['previousmessage']  = 'Mostrar mensaje anterior';
 $labels['nextmessages']     = 'Mostrar mensajes siguientes';
+$labels['nextmessage']      = 'Mostrar mensaje siguiente';
 $labels['backtolist']       = 'Volver a la lista de mensajes';
 
 $labels['viewsource']       = 'Mostrar código';

comment:3 Changed 8 years ago by thomasb

  • Owner changed from mtu to thomasb
  • Status changed from assigned to new

comment:4 Changed 8 years ago by thomasb

  • Resolution set to fixed
  • Status changed from new to closed

Commited with [421f5e31]

Note: See TracTickets for help on using tickets.