LDAP address auto-completion

[jasondixon]

I'd like to request LDAP email address auto-completion for the composition window. This feature already exists for the local addressbook.

[thomasb]

Later...

[entropy]

Just so it doenst get lost in the shuffle. Pierre Mauduit submitted a working patch for this one the dev list a little while ago. I've got it running on production installation of roundcube and it's worked great. Needs eventual refinement, but a great interim solution. Attached the diff.

[entropy]

Pierre Mauduit's ldap auto completion patch

[haralder]

There is one bug in this patch. If there are no contacts in the database addressbook, autocompletion does not work.

The reason is that autocompletion code is inside an IF loop: if ($DB->num_rows($sql_result))

{

[...]

/* LDAP autocompletion */ foreach ($CONFIGldap_public? as $ldapserv_config) {

I will try to correct it myself and post the patch to the patch, as soon as I have some time to learn php ;)

[haralder]

Sorry about the format.

There is one bug in this patch. If there are no contacts in the database addressbook, autocompletion does not work.

The reason is that autocompletion code is inside an IF loop:

if ($DB->num_rows($sql_result))
    {
    ...
    /* LDAP autocompletion */
    foreach ($CONFIG['ldap_public'] as $ldapserv_config)
        {

I will try to correct it myself and post the patch to the patch, as soon as I have some time to learn php ;)

[haralder]

Ok, this is the patch for an already patched compose.inc.

--- compose.inc-20070103	2007-01-03 14:15:20.000000000 +0100
+++ compose.inc	2007-01-03 14:28:15.000000000 +0100
@@ -790,6 +790,11 @@ if ($DB->num_rows($sql_result))
   while ($sql_arr = $DB->fetch_assoc($sql_result))
     if ($sql_arr['email'])
       $a_contacts[] = format_email_recipient($sql_arr['email'], rep_specialchars_output($sql_arr['name'], 'js'));
+  }
+
+if (!$a_contacts){
+  $a_contacts=array();
+  }

   /* LDAP autocompletion */
   foreach ($CONFIG['ldap_public'] as $ldapserv_config)
@@ -828,6 +833,7 @@ if ($DB->num_rows($sql_result))
       $cLdap->close ();
   }

+if ($a_contacts){
   $OUTPUT->add_script(sprintf("$JS_OBJECT_NAME.set_env('contacts', %s);", array2js($a_contacts)));
 }

[petrofsk]

Does anyone have this working in 0.1-rc2?

Thanks,

Warren

[arnested.dk]

I rewrote the patch to work with 0.1-rc2.

It guess it can be a bit slow on large or slow LDAP-servers.

So maybe make the use of LDAP-autocompletion so be configurable.

[arnested.dk]

LDAP-autocompletion-patch for 0.1-rc2

[till]

Comitted compose.patch, thanks!

[till]

Also introduced an additional check which compose.patch didn't cover. In compose.patch when people don't have ldap, they would still issue a search and this would lead to errors (due to no ldap config, etc.).

[hobstah]

Replying to arnested.dk:

It guess it can be a bit slow on large or slow LDAP-servers. So maybe make the use of LDAP-autocompletion so be configurable.

I have this issues right now. Bigger public LDAP should be queried for actual search string on keypress. I think it could be resolved with LDAP query limited with sizelimit=15 and run for each keypress.

Also, listing whole public LDAP within addressbook is IMHO "bad idea (tm)". Searching is great, but listing is bad.

I've tryed to resolve this on the other end - limiting results on server, but the way it's implemented right now, the autocomplete won't work or will work only for first N LDAP entries (N=sizelimit on server)

I think it's usable, the way it is now but have room for improvement. Will try to look into if have more time. Hope i'ts okay if i reopen it.

[alec]

It would be better to open a new feature request ticket. (I don't like old tickets and subject issue of this ticket was fixed).