No entry in config to change date/time format for today's emails.

[darkcoder]

The format used to display the time of emails that arrive the same day (today) is a 24 hour militar time hardcoded in program/include/main.inc

There should be a way to change that in the config file in the same way as the short/long date formats.

Below are some diffs I have done to add a new variable that allow the admin to also specify the hour format for emails received "Today".

config/main.inc.php

diff -urN roundcubemail.orig/config/main.inc.php roundcubemail/config/main.inc.php
--- roundcubemail.orig/config/main.inc.php       2006-07-06 02:36:37.000000000 -0400
+++ roundcubemail/config/main.inc.php   2006-07-06 02:37:11.000000000 -0400
@@ -102,6 +102,9 @@
 // the default locale setting
 $rcmail_config['locale_string'] = '';

+// use this format for emails that arrived today
+$rcmail_config['today_date'] = 'H:i';
+
 // use this format for short date display
 $rcmail_config['date_short'] = 'D H:i';

program/include/main.inc

diff -urN roundcubemail.orig/program/include/main.inc roundcubemail/program/include/main.inc
--- roundcubemail.orig/program/include/main.inc  2006-07-02 14:07:04.000000000 -0400
+++ roundcubemail/program/include/main.inc      2006-07-06 02:26:43.000000000 -0400
@@ -1533,7 +1533,7 @@

   // define date format depending on current time
   if ($CONFIG['prettydate'] && !$format && $timestamp > $today_limit)
-    return sprintf('%s %s', rcube_label('today'), date('H:i', $timestamp));
+    return sprintf('%s %s', rcube_label('today'), date($CONFIG['today_date'] ? $CONFIG['today_date'] : 'H:i', $timestamp));
   else if ($CONFIG['prettydate'] && !$format && $timestamp > $week_limit)
     $format = $CONFIG['date_short'] ? $CONFIG['date_short'] : 'D H:i';
   else if (!$format)

Code has also been included to provide the standard 'H:i' format in case the new variable today_date is not defined.

This change was applied to the svn trunk version 269

[mmarques]

The patch to config/main.inc.php should really go to config/main.inc.php.dist, asi the former one doesn't exist in the SVN trunk. ;-)

[thomasb]

More a feature request than a bug

[darkcoder]

If you change your date format to the US standard 12-hour format, then will understand that it looks more like a bug, than a request when you'll see not all entries change to the new format.

I can provide an updated diff in case needed.

[darkcoder]

Closing since it has been included in SVN 423 with a similar patch submitted by Doug Mandell recently.