Opened 7 years ago

Closed 6 years ago

#1466563 closed Feature Patches (fixed)

Multiple attachments cause email to be displayed incorrectly

Reported by: ryaner Owned by: nobody
Priority: 5 Milestone: 0.1-rc1
Component: Interface Version: 0.1-beta
Severity: trivial Keywords:
Cc:

Description (last modified by thomasb)

I just got a mail with 30odd attachments on it. This
caused RC to puch the email off to the right hand side
out of view of the mail window leaving me unable to
read the email. The list of attachments have also
exceeded the boundary which they are normally in.

Attachments (1)

Picture 3.png (66.6 KB) - added by jasondixon 7 years ago.
Screenshot of rendering issue

Download all attachments as: .zip

Change History (11)

comment:1 Changed 7 years ago by roundcube

Logged In: YES 
user_id=1262041

CSS issue.

comment:2 Changed 7 years ago by thomasb

  • Description modified (diff)
  • Milestone 0.1-beta2 deleted
  • Severity changed from critical to trivial

Later... having 30 attachments is not very usual.

comment:3 Changed 7 years ago by thomasb

  • Milestone set to later

comment:4 Changed 7 years ago by kwach

  • Milestone changed from later to 0.1stable

I think it should be a normal bug and for sure in to be done in stable release!
I had only three attachements, but with long names and email body was pushed out of the window.
Please resolve it to the stable release.

Changed 7 years ago by jasondixon

Screenshot of rendering issue

comment:5 Changed 7 years ago by jasondixon

I attached a screenshot of this issue in action. I also found that Roundcube refused to output the attachment bar/filename at all if the filename exceeds 64 chars. This is probably more appropriate for another bug report, if at all.

comment:6 Changed 7 years ago by thomasb

  • Milestone changed from 0.1-stable to 0.1-rc1

Any CSS experts out there?

comment:7 Changed 6 years ago by davo

Putting an :after selector on #attachment-list seems to do the trick. Also, change #attachment-lists height property to min-height. Removing border-bottom is just a cosmetic thing because it puts a slight gap in the preview pane view and doesn't really add anything to the full message view.

--- skins/default/mail.css      (revision 508)
+++ skins/default/mail.css      (working copy)
@@ -657,13 +657,22 @@
 {
   margin: 0px;
   padding: 0px 0px 0px 68px;
-  height: 18px;
+  min-height: 18px;
   list-style-image: none;
   list-style-type: none;
-  background: url(images/icons/attachment.png) 52px 1px no-repeat #DFDFDF;
-  border-bottom: 1px solid #FFFFFF;
+  background: url(images/icons/attachment.png) 52px 1px no-repeat #DFDFDF;
 }

+#attachment-list:after
+{
+  content: ".";
+  display: block;
+  height: 0;
+  font-size:0;
+  clear: both;
+  visibility:hidden;
+}
+
 #attachment-list li
 {
 /*  display: block; */

comment:8 Changed 6 years ago by r@…

Fix provided by davo solved the problem for me.

comment:9 Changed 6 years ago by r@…

  • Type changed from Bugs to Patches

comment:10 Changed 6 years ago by thomasb

  • Resolution changed from Accepted to fixed
  • Status changed from assigned to closed
  • Version changed from 0.1-rc1 to 0.1-beta

It even works in IE7!
Applied patch to Trunk ([ba033aeb])

Note: See TracTickets for help on using tickets.