Opened 7 years ago

Closed 6 years ago

#1457344 closed Feature Requests (fixed)

Creation/deletion of folders

Reported by: nobody Owned by: robin
Priority: 5 Milestone: 0.1-rc2
Component: Core functionality Version: None
Severity: minor Keywords:
Cc:

Description (last modified by thomasb)

Currently, we can create new folders, but they become
part of the main tree as a main folder. If I have a
folder called clients, and I want to add a new client
folder under that, there is no current way of doing
that in RCW.

I would really like to see this ability.

Under the folders tab there should also be a means to
delete folders.

Attachments (2)

IMG.JPG (33.6 KB) - added by seansan 6 years ago.
Example folder overview listing from v-webmail
rc_folders_list.png (14.9 KB) - added by thomasb 6 years ago.
Empty folders list after updating to r814

Download all attachments as: .zip

Change History (18)

comment:1 Changed 7 years ago by nobody

Logged In: NO 

delete ability is a trashcan next to the subscribed
checkbox.  So this is already taken care of, but the ability
to create child folders would be great :)

comment:2 Changed 7 years ago by nobody

Logged In: NO 

You can create a child folder if you know the basics of how the mail is stored 
in Maildir format by the IMAP server. If you wanted to make a folder "Vendors" 
a child of the parent folder "Business" you would create a new folder named 
"Vendors.Business"

Consider this a hack/kludge though. A real interface should be designed to 
make this intuitive and transparent to the user.

comment:3 Changed 7 years ago by nobody

Logged In: NO 

Opps. i mean to say "Business.Vendors" in the example below. Sorry, 
moderator please fix my goof.

comment:4 Changed 7 years ago by thomasb

  • Description modified (diff)
  • Milestone changed from 0.1-beta2 to 0.1rc1
  • Owner changed from roundcube to nobody
  • Severity changed from critical to minor
  • Status changed from assigned to new

Depending on your IMAP server, you can create nested folders by entering the correct delimiter. This is not the best solution and we will improve the folder configuration to do that.

Changed 6 years ago by seansan

Example folder overview listing from v-webmail

comment:5 Changed 6 years ago by seansan

Making a button next to the current ones with an option to create a subfolder would work (also see attachment).

The server can figure out the directory separator, send it along in a variable. The javascript after clicking on the button can then open a box (like the upload box) where a user enters the subfolder. The mother folder is captured when the button was clicked, the separator and name are joined and the sub folder is created.

comment:6 Changed 6 years ago by thomasb

  • Milestone changed from 0.1-rc1 to 0.2-beta

comment:7 Changed 6 years ago by thomasb

  • Milestone changed from 0.2-beta to 0.1-rc2
  • Owner changed from nobody to robin

Related to #1326393

comment:8 Changed 6 years ago by robin

  • Resolution changed from None to fixed
  • Status changed from new to closed

Done in SVN811.

comment:9 Changed 6 years ago by thomasb

  • Resolution fixed deleted
  • Status changed from closed to reopened

There are still some errors with this. The folder names are not displayed (I just see an empty list) and there are javascript errors in my Firefox:

Error: this.env.subscriptionrows["rcmrow" + id] has no properties
Source file: http://localhost/roundcube/trunk/program/js/app.js
Line: 2506

Changed 6 years ago by thomasb

Empty folders list after updating to r814

comment:10 Changed 6 years ago by robin

Thomas,

Do you by any chance have folder names with foreign characters? Your folder names are empty, which could explain the error.

comment:11 Changed 6 years ago by robin

  • Resolution set to fixed
  • Status changed from reopened to closed

Re-fixed in [dfa1f36c].

comment:12 follow-up: Changed 6 years ago by thomasb

  • Resolution fixed deleted
  • Status changed from closed to reopened

There's some more to fix until this feature is complete:

  • Check droptarget (don't highlight row and don't submit request to server) when drag&drop a folder to one of it's childs.
  • Remove all child rows when deleting a parent folder.
  • Incorrect sorting after parent folder was renamed.
  • Renaming a parent folder does not correctly alter the subscription list:
    Subfolders are still subscribed with "oldname/subfolder"

comment:13 in reply to: ↑ 12 ; follow-up: Changed 6 years ago by robin

Replying to thomasb:

  • Check droptarget (don't highlight row and don't submit request to server) when drag&drop a folder to one of it's childs.

Should have been fixed in [69f17cfd]. Please test; works for me.

  • Remove all child rows when deleting a parent folder.

Should have been fixed in [41841bc0]. Please test; works for me.

  • Incorrect sorting after parent folder was renamed.

Todo. Sorting is still broken in most of the folder management actions. I'm working on it.

  • Renaming a parent folder does not correctly alter the subscription list:
    Subfolders are still subscribed with "oldname/subfolder"

Fixed in [092bc0bc], though sorting is still broken (see above).

comment:14 in reply to: ↑ 13 ; follow-up: Changed 6 years ago by robin

  • Remove all child rows when deleting a parent folder.

Should have been fixed in [41841bc0]. Please test; works for me.

Obviously it doesn't. I'm working on a fix-fix :)

comment:15 in reply to: ↑ 14 Changed 6 years ago by robin

Replying to robin:

  • Remove all child rows when deleting a parent folder.

Should have been fixed in [41841bc0]. Please test; works for me.

Obviously it doesn't. I'm working on a fix-fix :)

[41841bc0] was undone in [ca2b4ddf] because deleting children should be done in one sweep. That's now fixed in [97a65664].

comment:16 Changed 6 years ago by thomasb

  • Resolution set to fixed
  • Status changed from reopened to closed

OK, we'll close this for now.

Note: See TracTickets for help on using tickets.