Opened 8 years ago

Closed 6 years ago

Last modified 5 years ago

#1327068 closed Bugs (fixed)

Opening large message fails

Reported by: jjongsma Owned by: thomasb
Priority: 10 - Lowest Milestone: 0.1-rc1
Component: PHP backend Version:
Severity: major Keywords:
Cc:

Description (last modified by thomasb)

When I try to open a large message (507 KB, all text,
no attachments), the status bar displays "Loading..."
and nothing happens, no matter how long I wait.
Clicking another folder or opening another message
clears the status message.

Attachments (3)

problem-mail (5.5 KB) - added by Voyageur 7 years ago.
Mail not displaying correctly on rev320
problem_mail.txt (4.1 KB) - added by brian 6 years ago.
Source of the Body of an Email that displays blank from r320 - r500. Displays properly in r319.
empty_mail_source.zip (2.3 KB) - added by brian 6 years ago.
Full Source of Email... thomas, is this what you need?

Download all attachments as: .zip

Change History (28)

comment:1 Changed 8 years ago by jjongsma

Logged In: YES 
user_id=728145

On further research this was actually an out-of-memory error
in PHP.  My memory is set fairly low (8 MB), but a 500 KB
message shouldn't eat that all up.  There must be something
inefficient going on.

comment:2 Changed 7 years ago by nobody

Logged In: NO 

i just found that yo open a 11Mb email, i need to setup the
php to allow 120Mb of ram per script... yep there is
something not exactly right 8)


comment:3 Changed 7 years ago by roundcube

Logged In: YES 
user_id=1262041

Does this problem still exist with the latest beta-release?

comment:4 Changed 7 years ago by thomasb

  • Description modified (diff)
  • Milestone changed from 0.1-beta2 to 0.1rc1
  • Severity changed from critical to major

Needs some rewrite of message parsing...

comment:5 Changed 7 years ago by brubaker

  • Milestone changed from 0.1rc1 to 0.1-beta2
  • Priority changed from 5 to 10
  • Version 0.1-alpha deleted

I think this is an severe Bug...
Many Users have bigger Mails and so they can's use Roundcube...

comment:6 Changed 7 years ago by thomasb

  • Milestone changed from 0.1-beta2 to 0.1stable
  • Owner changed from roundcube to thomasb
  • Status changed from assigned to new

Issue is too big for 0.1beta2. Please let the developers assign milestones!

comment:7 Changed 7 years ago by thomasb

  • Milestone changed from 0.1stable to 0.1rc1
  • Status changed from new to assigned

Fetch message structure only from IMAP server and the whole message.

comment:8 Changed 7 years ago by brubaker

is there a timelime for this bug?
Can you describe the solution in more detail, maybe i can fix it by myself and provide a patch :)

comment:9 Changed 7 years ago by thomasb

Just commited a changeset for this ticket. Testing is required now.

comment:10 Changed 7 years ago by mtu

A message of 1082KB that wouldn't load in earlier versions now opens fine in revision 320. Good work, Thomas :)

comment:11 Changed 7 years ago by brubaker

A message with 2 attachments and 8mb works now fine...
The only Problem now ist, that there is no option to download the items.

comment:12 Changed 7 years ago by Voyageur

I recently updated my SVN copy of roundcube (current 322 revision) and this update from revision 320 broke the display of some (simple) mails.

When I look at a mail, the headers are correct but the mail body is empty... A revert to rev319 and it appears OK again.

I'l attach such a mail, but they are not fancy (automated reports from the portage upgrades, gentoo server).

Changed 7 years ago by Voyageur

Mail not displaying correctly on rev320

comment:13 Changed 7 years ago by thomasb

  • Resolution changed from Accepted to fixed
  • Status changed from assigned to closed

Probem occurs when Content-Type header is missing. Fixed in [58afbe95].

comment:14 Changed 7 years ago by Voyageur

Indeed, no more 'phantom' empy mails here with [58afbe95] :)

comment:15 Changed 7 years ago by brubaker

  • Resolution fixed deleted
  • Status changed from closed to reopened

Thx for the patch, the message can now displayed without any problem...

The only Problem now ist, that there is no option to download the attachments.
I've tested it with IE and Firefox. In Firefox you can download the attachments, but they are all renamed as attachment.ext.htm. In IE the download breaks with no result.
When you wait 1 minute it works. I dont know why

comment:16 Changed 7 years ago by thomasb

I guess we need a test message for this. Usually attachments are listed above the message body and the "option" to download them is to click the link.

comment:17 Changed 7 years ago by brubaker

I've uploaded the mail to https://securetdb.bnet.at/bigmail.msg.gz .
Can't post it here, not enough post size.
I've also created a Testaccount @ my roundcube, feel free to test whatever you want...
Link: https://securetdb.bnet.at/roundcubemail/
User: m123456b3
pwd: roundcube

There you can see that you can open the mail, but download doesnt work. Also forwarding the mail fails with no error.

comment:18 Changed 7 years ago by thomasb

Download works for me. The browser fails to play the movies inline because RoundCube does not send a Content-Length header with it. This is because we don't know the real size of the part. The size information provided by the IMAP server only represents the size of the part in it's encoded (mostly base64) form. This cannot be used here.

comment:19 Changed 6 years ago by seansan

Just wanted to add that with v-webmail large messsages where also a problem. I think the solution here wa to fetch size, details etc ... but no to load it into memory.

When downloading the file was piped directly to download, line for line

http://v-webmail.cvs.sourceforge.net/v-webmail/v-webmail/includes/mailaccess/

comment:20 Changed 6 years ago by tomekp

  • Milestone changed from 0.1-rc1 to 0.1-stable

comment:21 Changed 6 years ago by thomasb

  • Milestone changed from 0.1-stable to 0.1-rc1

Please don't change assigned tickets!

comment:22 Changed 6 years ago by brian

I just found an email that is empty. I traced the issue to the program/steps/mail/func.inc & show.inc files. I am currently running [ff52bee1]. If I revert the two files mentioned to [89406f36], the email displays. If I update them to [8d4bcda8], I again get a blank email. I will create an attachment of the body of the email for test purposes.

Changed 6 years ago by brian

Source of the Body of an Email that displays blank from r320 - r500. Displays properly in r319.

comment:23 Changed 6 years ago by thomasb

Please provide the full message source in order to test it.

Changed 6 years ago by brian

Full Source of Email... thomas, is this what you need?

comment:24 Changed 6 years ago by thomasb

Your sample message does not contains the required MIME-Version header.

From RFC 1341:

Messages composed in accordance with this document MUST
include such a header field, with the following verbatim
text:

  MIME-Version: 1.0

Since message parsing is now done by the IMAP server, we cannot fix this problem within RoundCube.

comment:25 Changed 6 years ago by thomasb

  • Resolution set to fixed
  • Status changed from reopened to closed

Close it for 0.1-rc1

Note: See TracTickets for help on using tickets.