Opened 8 years ago

Closed 8 years ago

#1323578 closed Bugs (Fixed)

Adding multiple Re: to subject

Reported by: roundcube Owned by: roundcube
Priority: 5 Milestone:
Component: PHP backend Version: None
Severity: Keywords:
Cc:

Description

When replying to a message that already contains 'Re:'
in its subject, a new Re: will be added. This results
in a subject like "Re: Re: Re: Our conversation". Check
for Re: before adding one.

Change History (2)

comment:1 Changed 8 years ago by rpoulton

Logged In: YES 
user_id=19991

Fix: In file program/steps/mail/compose.inc, replace lines
404-410, which are currently:
  // create a reply-subject
  else if (isset($REPLY_MESSAGE['subject']))
    $subject = 'Re: '.$REPLY_MESSAGE['subject'];

  // create a forward-subject
  else if (isset($FORWARD_MESSAGE['subject']))
    $subject = 'Fwd: '.$FORWARD_MESSAGE['subject'];

with the following:
  // create a reply-subject
  else if (isset($REPLY_MESSAGE['subject'])) {
    if (eregi("^Re: ", $REPLY_MESSAGE['subject'])) {
      $subject = $REPLY_MESSAGE['subject'];
    } else {
      $subject = 'Re: '.$REPLY_MESSAGE['subject'];
    }
  }

  // create a forward-subject
  else if (isset($FORWARD_MESSAGE['subject'])) {
    if (eregi("^Fwd: ", $FORWARD_MESSAGE['subject'])) {
      $subject = $FORWARD_MESSAGE['subject'];
    } else {
      $subject = 'Fwd: '.$FORWARD_MESSAGE['subject'];
    }
  }

This will only put a 'Re:' (or 'Fwd:' if it's a foward) if
one doesn't already exist. It's case-insensitive, so if
there is a RE:/Re:/re: at the start of the subject it won't
add another one.

I've also forwarded this to the dev list.

comment:2 Changed 8 years ago by roundcube

  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.